Commit: a8eb6c1ea6ef2be959af8f81a8ddfc3fab65d07c - mingw-get (git)

The MinGW.org Installation Manager Tool

Commit MetaInfo

• Revision: a8eb6c1ea6ef2be959af8f81a8ddfc3fab65d07c (tree)
• Time: 2013-01-08 22:10:19
• Author: Keith Marshall <keithmarshall@user...>
• Commiter: Keith Marshall

Log Message

Avoid unnecessary reloading of package list.

Change Summary

• modified: ChangeLog
• modified: src/guiexec.cpp

Incremental Difference

--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2013-01-08  Keith Marshall  <[e-mail]>
 
+	Avoid unnecessary reloading of package list.
+
+	* src/guiexec.cpp (AppWindowMaker::OnCommand) [IDM_REPO_APPLY]:
+	Do not reload package list after processing; update it in place.
+
[phone]  Keith Marshall  <[e-mail]>
+
 	Avoid potential heap corruption in action scheduler.
 
 	* src/guiexec.cpp (pkgActionItem::Clear): Factor out; relocate to...

--- a/src/guiexec.cpp
+++ b/src/guiexec.cpp
@@ -650,9 +650,6 @@ long AppWindowMaker::OnCommand( WPARAM cmd )
 	   * actions schedule, remove all marker icons, and refresh
 	   * the package list to reflect current status.
 	   */
-#if 0     /* FIXME: we'd like to just do this in place, but doing
-	   * so seems to cause mingw-get to become unstable...
-	   */
 	  pkgListViewMaker pkglist( PackageListView );
 	  pkglist.UpdateListView();
 	  
@@ -664,17 +661,7 @@ long AppWindowMaker::OnCommand( WPARAM cmd )
 	  pkglist.MarkScheduledActions(
 	      pkgData->ClearScheduledActions( ACTION_PRESERVE_FAILED )
 	    );
-#else
-	  /* ...so, for the time being, we must force a complete
-	   * reload of the package list; (note that this has the
-	   * side effect of clearing any residual action schedule,
-	   * so we lose any potential record of failed actions).
-	   */
-	  ClearPackageList();
-	  LoadPackageData( false );
-	  UpdatePackageList();
-	  UpdateDataSheet();
-#endif
+
 	  /* Clearing the schedule of actions may also affect the
 	   * validity of menu options; update accordingly.
 	   */