Commit: 3fb62f9551515dd48e211ddbeb3fb5bb36130198 - medialist-cli (git)

CLI interface to medialist (fossil mirror)

Commit MetaInfo

• Revision: 3fb62f9551515dd48e211ddbeb3fb5bb36130198 (tree)
• Time: 2023-02-11 13:46:12
• Author: mio <stigma@disr...>
• Commiter: mio

Log Message

MediaList (library) v0.2.0

More of a fix where the ml_fetch_all function would call
std.string.strip on the mTSV line before splitting on a TAB, this
resulted in a RangeError being thrown if the number of "sections" didn't
match the number of "headers", even though they actually did in the .tsv
file.

NOTE: This still will through if there is a genuine mismatch between the number of headers or the number of fields in the file.

FossilOrigin-Name: 6a0938bdd1c5797799e3309637e6f7d61640b57a1f490a1e7291020bc0a98dfd

Change Summary

• modified: medialist.d

Incremental Difference

--- a/medialist.d
+++ b/medialist.d
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2022 dawning.
+ * Copyright (C) 2022, 2023 dawning.
  *
  * This file is part of medialist-cli.
  *
@@ -28,6 +28,26 @@ import std.path;
 import std.stdio;
 import std.string;
 
+/**
+ * Enumeration string containing the verison of MediaList.
+ * 
+ * Since: 0.2.0
+ */
+enum string MediaListVersion = "0.2.0";
+
+/**
+ * Enumeration array of int containing the version of MediaList.
+ * 
+ * Version represents the Major.Minor.Patch.
+ * 
+ * Major version changes represent the modification or removal of an existing
+ * API.  Patch versions represent compile-time fixes.  Minor versions represent
+ * all other changes.
+ *
+ * Since: 0.2.0
+ */
+enum int[3] MediaListVersionA = [0, 2, 0];
+
 struct MediaList
 {
     immutable string filePath;
@@ -371,6 +391,7 @@ MediaListItem[] ml_fetch_all(MediaList* list, MLError* err = null)
 
     File listFile = File(list.filePath);
     list.isOpen = true;
+    scope(exit) list.isOpen = false;
 
     string line;
     bool pastHeader = false;
@@ -421,15 +442,19 @@ MediaListItem[] ml_fetch_all(MediaList* list, MLError* err = null)
             continue;
         }
 
-        string[] sections = line.strip().split("\t");
+        // Separate the split and strip so we don't remove any
+        // trailing \t which may be used as a placeholder.
+        string[] sections = line.split("\t");
+        sections[$ - 1] = sections[$ - 1].strip;
 
         items ~= MediaListItem(sections[titleIndex],
-            sections[progressIndex], sections[statusIndex], sections[startIndex],
-            sections[endIndex], sections[lastIndex], true);
+            sections[progressIndex],
+            sections[statusIndex],
+            sections[startIndex],
+            sections[endIndex],
+            sections[lastIndex], true);
     }
 
-    list.isOpen = false;
-
     return items;
 }