Commit: 620c454a5c9286d2bc8fd91da2a2735e8453a104 - MolDS (git)

Commit MetaInfo

• Revision: 620c454a5c9286d2bc8fd91da2a2735e8453a104 (tree)
• Time: 2013-05-22 14:00:44
• Author: Mikiya Fujii <mikiya.fujii@gmai...>
• Commiter: Mikiya Fujii

Log Message

validation for excited states dynamics with ZindoS is updated. #31221

git-svn-id: https://svn.sourceforge.jp/svnroot/molds/trunk@1345 1136aad2-a195-0410-b898-f5ea1d11b9d8

Change Summary

• modified: doc/README.txt
• modified: src/base/InputParser.cpp
• modified: src/base/InputParser.h

Incremental Difference

--- a/doc/README.txt
+++ b/doc/README.txt
@@ -103,7 +103,7 @@ CAPABILITIES:
    ---------|-----|-----|--------|--------|--------|--------|----------|----------|--------------|--------------|-----------------|
    INDO     | OK  | --  | --     | --     | OK     | --     | --       | --       | --           | --           | --              |
    ---------|-----|-----|--------|--------|--------|--------|----------|----------|--------------|--------------|-----------------|
-   ZINDO/S  | OK  | OK  | OK     | --     | OK     | OK     | OK       | --       | OK           | --           | --              |
+   ZINDO/S  | OK  | OK  | OK     | OK     | OK     | OK     | OK       | OK       | OK           | OK           | --              |
    ---------|-----|-----|--------|--------|--------|--------|----------|----------|--------------|--------------|-----------------|
    MNDO     | OK  | OK  | OK     | OK     | OK     | OK     | OK       | OK       | OK           | OK           | OK              |
    ---------|-----|-----|--------|--------|--------|--------|----------|----------|--------------|--------------|-----------------|

--- a/src/base/InputParser.cpp
+++ b/src/base/InputParser.cpp
@@ -78,10 +78,14 @@ void InputParser::SetMessages(){
       = "Error in base::InputParser::GetInputTerms: Input file is empty.\n"; 
    this->errorMessageNotFoundInputFile
       = "Error in base::InputParser::StoreInputTermsFromFile: Not found.\n"; 
+   this->errorMessageNonValidTheoriesMD
+      = "Error in base::InputParser::ValidateMdConditions: Theory you set is not supported for MD.\n";
    this->errorMessageNonValidExcitedStatesMD
       = "Error in base::InputParser::ValidateMdConditions: Excited state on which MD runs or CIS condition are wrong.\n";
    this->errorMessageNonValidExcitedStatesMC
       = "Error in base::InputParser::ValidateMcConditions: Excited state on which MC runs or CIS condition are wrong.\n";
+   this->errorMessageNonValidTheoriesRPMD
+      = "Error in base::InputParser::ValidateRpmdConditions: heory you set is not supported for RMPD.\n";
    this->errorMessageNonValidExcitedStatesRPMD
       = "Error in base::InputParser::ValidateRpmdConditions: Excited state on which RPMD runs or CIS condition are wrong.\n";
    this->errorMessageNonValidTheoriesNASCO
@@ -90,6 +94,8 @@ void InputParser::SetMessages(){
       = "Error in base::InputParser::ValidateNascoConditions: The Number of electronic states of NASCO should be not over the number of CIS excited states plus 1.\n";
    this->errorMessageNonValidInitialElectronicStateNASCO
       = "Error in base::InputParser::ValidateNascoConditions: The initial electronic states for NASCO should be set to one of the electronic eigenstates used in NASCO.\n";
+   this->errorMessageNonValidTheoriesOptimization
+      = "Error in base::InputParser::ValidateOptimizationConditions: heory you set is not supported for optimization.\n";
    this->errorMessageNonValidExcitedStatesOptimization
       = "Error in base::InputParser::ValidateOptimizationConditions: Excited state on which optimization is carried out or CIS condition are wrong.\n";
    this->errorMessageNonValidElectronicStateFrequencies
@@ -1371,8 +1377,7 @@ void InputParser::ValidateMdConditions(const Molecule& molecule) const{
    // Validate theory
    if(theory == CNDO2 || theory == INDO ){
       stringstream ss;
-      ss << this->errorMessageNonValidExcitedStatesMD;
-      ss << this->errorMessageElecState << targetStateIndex << endl;
+      ss << this->errorMessageNonValidTheoriesMD;
       ss << this->errorMessageTheory << TheoryTypeStr(theory) << endl;
       throw MolDSException(ss.str());
    }
@@ -1383,7 +1388,7 @@ void InputParser::ValidateMdConditions(const Molecule& molecule) const{
       this->ValidateCisConditions(molecule);
    }
    int numberExcitedStatesCIS = Parameters::GetInstance()->GetNumberExcitedStatesCIS();
-   if(numberExcitedStatesCIS < targetStateIndex){
+   if(groundStateIndex < targetStateIndex && numberExcitedStatesCIS < targetStateIndex){
       stringstream ss;
       ss << this->errorMessageNonValidExcitedStatesMD;
       ss << this->errorMessageElecState << targetStateIndex << endl;
@@ -1425,10 +1430,9 @@ void InputParser::ValidateRpmdConditions(const Molecule& molecule) const{
    int targetStateIndex = Parameters::GetInstance()->GetElectronicStateIndexRPMD();
    TheoryType theory = Parameters::GetInstance()->GetCurrentTheory();
    // Validate theory
-   if(theory == CNDO2 || theory == INDO || (theory == ZINDOS && groundStateIndex < targetStateIndex)){
+   if(theory == CNDO2 || theory == INDO ){
       stringstream ss;
-      ss << this->errorMessageNonValidExcitedStatesRPMD;
-      ss << this->errorMessageElecState << targetStateIndex << endl;
+      ss << this->errorMessageNonValidTheoriesRPMD;
       ss << this->errorMessageTheory << TheoryTypeStr(theory) << endl;
       throw MolDSException(ss.str());
    }
@@ -1439,7 +1443,7 @@ void InputParser::ValidateRpmdConditions(const Molecule& molecule) const{
       this->ValidateCisConditions(molecule);
    }
    int numberExcitedStatesCIS = Parameters::GetInstance()->GetNumberExcitedStatesCIS();
-   if(numberExcitedStatesCIS < targetStateIndex){
+   if(groundStateIndex < targetStateIndex && numberExcitedStatesCIS < targetStateIndex){
       stringstream ss;
       ss << this->errorMessageNonValidExcitedStatesRPMD;
       ss << this->errorMessageElecState << targetStateIndex << endl;
@@ -1489,9 +1493,9 @@ void InputParser::ValidateOptimizationConditions(const Molecule& molecule) const
    int targetStateIndex = Parameters::GetInstance()->GetElectronicStateIndexOptimization();
    TheoryType theory = Parameters::GetInstance()->GetCurrentTheory();
    // Validate theory
-   if(theory == CNDO2 || theory == INDO || (theory == ZINDOS && groundStateIndex < targetStateIndex)){
+   if(theory == CNDO2 || theory == INDO ){
       stringstream ss;
-      ss << this->errorMessageNonValidExcitedStatesOptimization;
+      ss << this->errorMessageNonValidTheoriesOptimization;
       ss << this->errorMessageElecState << targetStateIndex << endl;
       ss << this->errorMessageTheory << TheoryTypeStr(theory) << endl;
       throw MolDSException(ss.str());
@@ -1503,7 +1507,7 @@ void InputParser::ValidateOptimizationConditions(const Molecule& molecule) const
       this->ValidateCisConditions(molecule);
    }
    int numberExcitedStatesCIS = Parameters::GetInstance()->GetNumberExcitedStatesCIS();
-   if(numberExcitedStatesCIS < targetStateIndex){
+   if(groundStateIndex < targetStateIndex && numberExcitedStatesCIS < targetStateIndex){
       stringstream ss;
       ss << this->errorMessageNonValidExcitedStatesOptimization;
       ss << this->errorMessageElecState << targetStateIndex << endl;

--- a/src/base/InputParser.h
+++ b/src/base/InputParser.h
@@ -35,12 +35,15 @@ private:
    void SetMessages();
    std::string errorMessageInputFileEmpty;
    std::string errorMessageNotFoundInputFile; 
+   std::string errorMessageNonValidTheoriesMD;
    std::string errorMessageNonValidExcitedStatesMD;
    std::string errorMessageNonValidExcitedStatesMC;
+   std::string errorMessageNonValidTheoriesRPMD;
    std::string errorMessageNonValidExcitedStatesRPMD;
    std::string errorMessageNonValidTheoriesNASCO;
    std::string errorMessageNonValidNumberExcitedStatesNASCO;
    std::string errorMessageNonValidInitialElectronicStateNASCO;
+   std::string errorMessageNonValidTheoriesOptimization;
    std::string errorMessageNonValidExcitedStatesOptimization;
    std::string errorMessageNonValidElectronicStateFrequencies;
    std::string errorMessageNonValidTheoryFrequencies;