external-koush-Superuser

Fork

Fixes for koush's Superuser on marshmallow

Koush Superuser uses Apache http client imports, which are
deprecated on API 23 (marshmallow).

As google recommends, it was replaced by HttpURLConnection

References:
http://developer.android.com/intl/pt-br/about/versions/marshmallow/android-6.0-changes.html
http://stackoverflow.com/questions/9856195/how-to-read-an-http-input-stream
https://developer.android.com/intl/pt-br/reference/java/net/HttpURLConnection.html

android: fix 64-bit targets building errors

Patch to avoid the following building errors:

Import includes file: out/target/product/x86_64/obj/EXECUTABLES/su_intermediates/import_includes
target C: su <= external/koush/Superuser/Superuser/jni/su/su.c
external/koush/Superuser/Superuser/jni/su/su.c: In function 'socket_send_request':
external/koush/Superuser/Superuser/jni/su/su.c:397:5: error: implicit declaration of function 'htonl' [-Werror=implicit-function-declaration]
write_token(fd, "version", PROTO_VERSION);
^

target C: su <= external/koush/Superuser/Superuser/jni/su/pts.c
Export includes file: external/koush/Superuser/Android.mk -- out/target/product/x86_64/obj/EXECUTABLES/su_intermediates/export_includes
target Prebuilt: clatd.conf (out/target/product/x86_64/obj/ETC/clatd.conf_intermediates/clatd.conf)
external/koush/Superuser/Superuser/jni/su/pts.c: In function 'pts_open':
external/koush/Superuser/Superuser/jni/su/pts.c:121:5: error: implicit declaration of function 'strncpy' [-Werror=implicit-function-declaration]
strncpy(slave_name, sn_tmp, slave_name_size);
^

Fix Superuser on 64 bits target

- An export to "/system/lib" is not required and cause problems
as this is a 32 bits lib dir only
- When writing to socket, datatype size_t was used, which is
4 bytes on 32 bits target and 8 bytes on 64 bits.
Superuser expects it as a 4 bytes length. So, it was
replaced by "uint32_t" datatype

Superuser: Don't set root access as a default fallback option.

Problem: if persist.sys.root_access is not present, it will set
root access anyways regardless of build type
fix: set to 0 anyway which is no root.

Change-Id: I3665d965a6fbb21fd26a8d7256579eb272b608f0

Fix security, tighter str comparison, fix warnings

* When reading our and the caller's path, we were mistakingly reading only the
first sizeof(char*) characters, so anything that was running from a path
starting with '/sys' was being considered to be us
* strcmp'ing strings instead of comparing only for the length of the first of
them. Avoids possible executions from /system/xbin/suwhatever .
* Fixed several compile-time warnings

Change-Id: I2af07f7bf5078acd0c36bd22b74fbc01276957be

su: Fix verification fails when the client isn't setuid

Don't take an uid-0 caller as a trust guarantee. Trust only values
that are delivered by a remote that's the same as ourselves (su-as-client
talking to su-as-daemon) and use PEERCRED to assert the remote UID and PID
on any other case.
This fixes credential validation when the client isn't always running with
root privileges via setuid

Change-Id: Iad8fc271d9c6aae7f6654af2ef9db638f2165af1

Update the Superuser settings drawable

Change-Id: I9057b5fc18d2669b29c9e8dde1b121c23cb57744

Invert theme

Use light theme as a stopgap readibility fix until this gets a
Material overhaul

Change-Id: I5f77d96daee34700d3cea7bd4e07728fdc3ca2d2

init: Update daemon contexts for enforcing selinux policies

Change-Id: I6c33445f741aab3ac89f1bbfa096fbe65d44ad66

Automatic translation import

Change-Id: I6ebb9dad16aa8f482d179aaa8b95d03a962594a5

Automatic translation import

Change-Id: Ic1a347ac7fb63a49188e378857d3fa1c52480df0

Automatic translation import

Change-Id: I8f23ffbd432ed49587bdaf93bfcfe3ceea039e7f

Automatic translation import

Change-Id: Iacfd50ee4e7aa3bc6b6622fa1475c43f76322a79

Automatic translation import

Change-Id: Ia2949c44b1fee77823343a93b5044a81644ed58e

SU: Use different strings for notification summary & popup list

Change-Id: I46017bd0dec40b57c27e951a863662d1a6afb72e

Automatic translation import

Change-Id: Ic9c9cb50bc532b167a7643f2748cc75af4fef972

Automatic translation import

Change-Id: I04b01276a3c079a0d4b6ad187a3c0707da364166

su: Don't forcefully add the bin symlink to the installed packages

The LOCAL_MODULE dependency is enough to get it deployed when the
actual binary is built. Adding it to the default modules was leaving
a dangling dead symlink in cases where su isn't bundled (user builds)

Change-Id: I1364cf6537993a8b72bce8c178a7aeec080c9eb3

Superuser: Remove unused translations

Change-Id: Iecd28faacb070e753305bc52395586f429d58723

Rename allow and deny strings.

Both are also present in the Settings app's resources, which we
integrate into.

Change-Id: Ib08e84995a946d3fdf22f1bb61871c4e1429538e

Automatic translation import

Change-Id: I78b6d486ab5203fabbb2f2b0763058c76b927d0f

Automatic translation import

Change-Id: Iaf971bba9546c9531685265a899bbff635e88d37

Prevent clickjacking of superuser requests

Enable filterTouchesWhenObscured on the accept request button to prevent
possible clickjacking attacks. This is a measure used in many sensitive
dialogs (app installation, backup & VPN) in AOSP.

Change-Id: I33c18c449c909b97b29b981bffe7f3095adee506

Automatic translation import

Change-Id: If0fecb26f20c7e4f6a8d4a12c7a5faf49f0d229c

Revert "Superuser: Don't duplicate 'Allow' string"

On a second thought, this is plain confusing for translators.
I'd like to keep the ~350 people who translate happy.

This reverts commit 6af4772b0172cb3e0b70f2ab5b961139f404e621.

Change-Id: I6b1a82ed3292aa98b0d340d6dd9e90de8791b05d

Superuser: Don't duplicate 'Allow' string

Change-Id: I98085f8da3ea9f6f6b8899d0bb0cda0cc1d503aa

Superuser: Add a string for JA translation

Change-Id: I16d7ad52fcb276b25c86390485afdafbfd94a41a

Automatic translation import

Change-Id: Ie301344eef330ed6682c68303390c35d60e9ad1b

Automatic translation import

Change-Id: I4bc9436aae4562091b06c8443b73b6192a0a0b41

Automatic translation import

Change-Id: If5ef6c83a467de35f4f068131f0865919f8cabf1