Commit: fa42dd2e8328560e65c888277ab146810c1763a8 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: fa42dd2e8328560e65c888277ab146810c1763a8 (tree)
• Time: 2016-09-22 20:26:44
• Author: Anton Kolesov <Anton.Kolesov@syno...>
• Commiter: Anton Kolesov

Log Message

arc: Fix ARI warning for printf(%p)

Replace printf ("%p") with printf ("%s", host_address_to_string ()). Printing
host addrss might make sense here because pointers can be null and this would
affect how function behaves.

This particular warning is printed only when option -Wari is passed to
contrib/ari/gdb_ari.sh

gdb/ChangeLog:

* arc-tdep.c: Fix ARI warning for printf(%p).

Change Summary

• modified: gdb/ChangeLog
• modified: gdb/arc-tdep.c

Incremental Difference

--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
[phone]  Anton Kolesov  <[e-mail]>
+
+	* arc-tdep.c: Fix ARI warning for printf(%p).
+
 2016-09-21  Anton Kolesov  <[e-mail]>
 
 	* MAINTAINERS (Write After Approval): Add Anton Kolesov.

--- a/gdb/arc-tdep.c
+++ b/gdb/arc-tdep.c
@@ -574,8 +574,9 @@ arc_return_value (struct gdbarch *gdbarch, struct value *function,
 			  || TYPE_LENGTH (valtype) > 2 * ARC_REGISTER_SIZE);
 
   if (arc_debug)
-    debug_printf ("arc: return_value (readbuf = %p, writebuf = %p)\n",
-		  readbuf, writebuf);
+    debug_printf ("arc: return_value (readbuf = %s, writebuf = %s)\n",
+		  host_address_to_string (readbuf),
+		  host_address_to_string (writebuf));
 
   if (writebuf != NULL)
     {