Commit: ea68593bd2c649a73754e150340ba3400c007682 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: ea68593bd2c649a73754e150340ba3400c007682 (tree)
• Time: 2020-07-02 12:21:12
• Author: Tom Tromey <tom@trom...>
• Commiter: Tom Tromey

Log Message

Use complete_on_enum in tui_reggroup_completer

tui_reggroup_completer has an "XXXX" comment suggesting the use of
complete_on_enum. This patch implements this suggestion.

gdb/ChangeLog
2020-07-01 Tom Tromey <[e-mail]>

* tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.

Change Summary

• modified: gdb/ChangeLog
• modified: gdb/tui/tui-regs.c

Incremental Difference

--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
[phone]  Tom Tromey  <[e-mail]>
+
+	* tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.
+
 2020-07-01  Fangrui Song  <[e-mail]>
 
 	* dwarf2/read.c (lnp_state_machine::check_line_address): Test -1.

--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -631,18 +631,11 @@ tui_reggroup_completer (struct cmd_list_element *ignore,
 			completion_tracker &tracker,
 			const char *text, const char *word)
 {
-  static const char *extra[] = { "next", "prev", NULL };
-  size_t len = strlen (word);
-  const char **tmp;
+  static const char * const extra[] = { "next", "prev", NULL };
 
   reggroup_completer (ignore, tracker, text, word);
 
-  /* XXXX use complete_on_enum instead?  */
-  for (tmp = extra; *tmp != NULL; ++tmp)
-    {
-      if (strncmp (word, *tmp, len) == 0)
-	tracker.add_completion (make_unique_xstrdup (*tmp));
-    }
+  complete_on_enum (tracker, extra, text, word);
 }
 
 void _initialize_tui_regs ();