Commit: c9753adb0153fbb5ce01583881862642e7f126af - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: c9753adb0153fbb5ce01583881862642e7f126af (tree)
• Time: 2020-07-02 12:21:14
• Author: Tom Tromey <tom@trom...>
• Commiter: Tom Tromey

Log Message

Remove useless "if' from tui-regs.c

tui_data_window::show_register_group had a useless "if" -- the
condition could never be false. This patch removes it.

gdb/ChangeLog
2020-07-01 Tom Tromey <[e-mail]>

* tui/tui-regs.c (tui_data_window::show_register_group): Remove
useless "if".

Change Summary

• modified: gdb/ChangeLog
• modified: gdb/tui/tui-regs.c

Incremental Difference

--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2020-07-01  Tom Tromey  <[e-mail]>
 
+	* tui/tui-regs.c (tui_data_window::show_register_group): Remove
+	useless "if".
+
[phone]  Tom Tromey  <[e-mail]>
+
 	* tui/tui-regs.c (tui_data_window::show_register_group): Update.
 	* tui/tui-regs.h (struct tui_data_item_window) <name>: Remove.
 

--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -257,15 +257,12 @@ tui_data_window::show_register_group (struct reggroup *group,
 	continue;
 
       data_item_win = &m_regs_content[pos];
-      if (data_item_win)
+      if (!refresh_values_only)
 	{
-	  if (!refresh_values_only)
-	    {
-	      data_item_win->item_no = regnum;
-	      data_item_win->highlight = false;
-	    }
-	  tui_get_register (frame, data_item_win, regnum, 0);
+	  data_item_win->item_no = regnum;
+	  data_item_win->highlight = false;
 	}
+      tui_get_register (frame, data_item_win, regnum, 0);
       pos++;
     }
 }