Commit: c802e8a76c4eaa3a8a62d7dcfe7be98bf718a2f0 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: c802e8a76c4eaa3a8a62d7dcfe7be98bf718a2f0 (tree)
• Time: 2020-06-16 20:41:28
• Author: Gary Benson <gbenson@redh...>
• Commiter: Gary Benson

Log Message

Add two missing return values in gdb.python/py-nested-maps.c

Two functions in gdb.python/py-nested-maps.c are missing return
values. This causes clang to fail to compile the file with the
following error:

warning: control reaches end of non-void function [-Wreturn-type]

This commit fixes, by causing the two functions to return pointers
to the objects they've just allocated and initialized. I didn't
investigate how this test had been passing with other compilers;
I'm assuming serendipity, that in each function the value to be
returned was already in the register it would need to be in to be
the function's return value.

gdb/testsuite/ChangeLog:

* gdb.python/py-nested-maps.c (create_map): Add missing return
value.
(create_map_map): Likewise.

Change Summary

• modified: gdb/testsuite/ChangeLog
• modified: gdb/testsuite/gdb.python/py-nested-maps.c

Incremental Difference

--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
[phone]  Gary Benson <[e-mail]>
+
+	* gdb.python/py-nested-maps.c (create_map): Add missing return
+	value.
+	(create_map_map): Likewise.
+
 2020-06-15  Tankut Baris Aktemur  <[e-mail]>
 
 	* gdb.base/jit-elf-so.exp: Refer to the global main_loader_basename

--- a/gdb/testsuite/gdb.python/py-nested-maps.c
+++ b/gdb/testsuite/gdb.python/py-nested-maps.c
@@ -62,6 +62,7 @@ create_map (const char *name)
   m->keys = NULL;
   m->values = NULL;
   m->show_header = 0;
+  return m;
 }
 
 void
@@ -85,6 +86,7 @@ create_map_map (void)
   mm->length = 0;
   mm->values = NULL;
   mm->show_header = 0;
+  return mm;
 }
 
 void