binutils_os216
Fork

Commit

Fix gdb.base/charset.exp with Clang

gdb.base/charset.exp fails to run with Clang, because of:

gdb compile failed, /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/charset.c:144:20: warning:

implicit conversion from 'int' to 'char' changes value from 162 to -94
[-Wconstant-conversion]

11, 162, 17);

/home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/charset.c:151:16: warning:

implicit conversion from 'int' to 'char' changes value from 167 to -89
[-Wconstant-conversion]

167,

/home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/charset.c:168:16: warning:

implicit conversion from 'int' to 'char' changes value from 167 to -89
[-Wconstant-conversion]

167,

3 warnings generated.

=== gdb Summary ===

# of untested testcases 1

Fix it by changing init_string to take unsigned char parameters.

gdb/testsuite/ChangeLog:

* gdb.base/charset.c (init_string): Change all char parameters to
unsigned char parameters.

--- a/gdb/testsuite/ChangeLog

+++ b/gdb/testsuite/ChangeLog

		@@ -1,5 +1,10 @@
1	1	2020-07-03 Pedro Alves <palves@redhat.com>
2	2
	3	+ * gdb.base/charset.c (init_string): Change all char parameters to
	4	+ unsigned char parameters.
	5	+
	6	+2020-07-03 Pedro Alves <palves@redhat.com>
	7	+
3	8	* gdb.base/call-sc.exp (start_scalars_test): Use
4	9	prepare_for_testing and don't try compiling with -DNO_PROTOTYPES.
5	10	* gdb.base/overlays.c: Remove references to PARAMS.

--- a/gdb/testsuite/gdb.base/charset.c

+++ b/gdb/testsuite/gdb.base/charset.c

		@@ -77,12 +77,21 @@ short short_array[3];
77	77	int int_array[3];
78	78	long long_array[3];
79	79
	80	+/* These are unsigned char so we can pass down characters >127 without
	81	+ explicit casts or warnings. */
	82	+
80	83	void
81	84	init_string (char string[],
82		- char x,
83		- char alert, char backspace, char form_feed,
84		- char line_feed, char carriage_return, char horizontal_tab,
85		- char vertical_tab, char cent, char misc_ctrl)
	85	+ unsigned char x,
	86	+ unsigned char alert,
	87	+ unsigned char backspace,
	88	+ unsigned char form_feed,
	89	+ unsigned char line_feed,
	90	+ unsigned char carriage_return,
	91	+ unsigned char horizontal_tab,
	92	+ unsigned char vertical_tab,
	93	+ unsigned char cent,
	94	+ unsigned char misc_ctrl)
86	95	{
87	96	int i;
88	97