Commit: 5707a07af2c282e87af1b060b4463fc083775649 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: 5707a07af2c282e87af1b060b4463fc083775649 (tree)
• Time: 2020-02-23 05:49:56
• Author: Tom Tromey <tom@trom...>
• Commiter: Tom Tromey

Log Message

Make dwarf2_compile_expr_to_ax static

I noticed that dwarf2_compile_expr_to_ax can be static. Nothing
outside of loc.c calls it.

gdb/ChangeLog
2020-02-22 Tom Tromey <[e-mail]>

* dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
* dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.

Change Summary

• modified: gdb/ChangeLog
• modified: gdb/dwarf2/loc.c
• modified: gdb/dwarf2/loc.h

Incremental Difference

--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2020-02-22  Tom Tromey  <[e-mail]>
 
+	* dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
+	* dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
+
[phone]  Tom Tromey  <[e-mail]>
+
 	* tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
 
 2020-02-22  Tom Tromey  <[e-mail]>

--- a/gdb/dwarf2/loc.c
+++ b/gdb/dwarf2/loc.c
@@ -2881,7 +2881,7 @@ get_ax_pc (void *baton)
    example, if the expression cannot be compiled, or if the expression
    is invalid.  */
 
-void
+static void
 dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc,
 			   unsigned int addr_size, const gdb_byte *op_ptr,
 			   const gdb_byte *op_end,

--- a/gdb/dwarf2/loc.h
+++ b/gdb/dwarf2/loc.h
@@ -242,26 +242,6 @@ extern const struct symbol_computed_ops dwarf2_loclist_funcs;
 extern const struct symbol_block_ops dwarf2_block_frame_base_locexpr_funcs;
 extern const struct symbol_block_ops dwarf2_block_frame_base_loclist_funcs;
 
-/* Compile a DWARF location expression to an agent expression.
-   
-   EXPR is the agent expression we are building.
-   LOC is the agent value we modify.
-   ARCH is the architecture.
-   ADDR_SIZE is the size of addresses, in bytes.
-   OP_PTR is the start of the location expression.
-   OP_END is one past the last byte of the location expression.
-   
-   This will throw an exception for various kinds of errors -- for
-   example, if the expression cannot be compiled, or if the expression
-   is invalid.  */
-
-extern void dwarf2_compile_expr_to_ax (struct agent_expr *expr,
-				       struct axs_value *loc,
-				       unsigned int addr_size,
-				       const gdb_byte *op_ptr,
-				       const gdb_byte *op_end,
-				       struct dwarf2_per_cu_data *per_cu);
-
 /* Determined tail calls for constructing virtual tail call frames.  */
 
 struct call_site_chain