Commit: 3c8ea5be24ecc76600b6cea36240449a84c0fc22 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: 3c8ea5be24ecc76600b6cea36240449a84c0fc22 (tree)
• Time: 2020-07-03 23:01:22
• Author: Pedro Alves <palves@redh...>
• Commiter: Pedro Alves

Log Message

Fix gdb.base/structs2.exp with Clang

gdb.base/structs2.exp fails to run with Clang, because of:

gdb compile failed, /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/structs2.c:16:14: warning:

implicit conversion from 'int' to 'signed char' changes value from 130 to
-126 [-Wconstant-conversion]

param_reg (130, 120, 33000, 32000);
~

/home/pedro/gdb/mygit/src/gdb/testsuite/gdb.base/structs2.c:16:24: warning:

implicit conversion from 'int' to 'short' changes value from 33000 to
-32536 [-Wconstant-conversion]

param_reg (130, 120, 33000, 32000);
~

2 warnings generated.

=== gdb Summary ===

# of untested testcases 1

Fix it by passing actual negative numbers.

gdb/testsuite/ChangeLog:

* gdb.base/structs2.c (main): Adjust second parem_reg call to
explicitly write negative numbers.
* gdb.base/structs2.exp: Adjust expected output.

Change Summary

• modified: gdb/testsuite/ChangeLog
• modified: gdb/testsuite/gdb.base/structs2.c
• modified: gdb/testsuite/gdb.base/structs2.exp

Incremental Difference

--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,11 @@
 2020-07-03  Pedro Alves  <[e-mail]>
 
+	* gdb.base/structs2.c (main): Adjust second parem_reg call to
+	explicitly write negative numbers.
+	* gdb.base/structs2.exp: Adjust expected output.
+
[phone]  Pedro Alves  <[e-mail]>
+
 	* gdb.base/charset.c (init_string): Change all char parameters to
 	unsigned char parameters.
 

--- a/gdb/testsuite/gdb.base/structs2.c
+++ b/gdb/testsuite/gdb.base/structs2.c
@@ -13,7 +13,7 @@ main ()
 
   bkpt = 0;
   param_reg (120, 130, 32000, 33000);
-  param_reg (130, 120, 33000, 32000);
+  param_reg (-120, 130, -32000, 33000);
 
   return 0;
 }

--- a/gdb/testsuite/gdb.base/structs2.exp
+++ b/gdb/testsuite/gdb.base/structs2.exp
@@ -49,5 +49,5 @@ if [test_compiler_info gcc-3-*] {
   setup_xfail hppa*-* gcc/15860
 }
 gdb_test "continue" \
-    ".*pr_char=-126.*pr_uchar=120.*pr_short=-32536.*pr_ushort=32000.*bkpt = 1.*" \
+    ".*pr_char=-120.*pr_uchar=130.*pr_short=-32000.*pr_ushort=33000.*bkpt = 1.*" \
     "structs2 continue2"