Commit: 2846942c7c83d007106cdcf1108ceedb50e1d4ec - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revision: 2846942c7c83d007106cdcf1108ceedb50e1d4ec (tree)
• Time: 2020-03-11 14:33:35
• Author: Alan Modra <amodra@gmai...>
• Commiter: Alan Modra

Log Message

powerpc64-ld infinite loop

If this code dealing with possible conversion of inline plt sequences
is ever executed, ld will hang. A binary with such sequences and of
code size larger than approximately 90% the reach of an unconditional
branch is the trigger. Oops.

* elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.

(cherry picked from commit 435edf0bf231240ccecb474b74ebb49dc8db2633)

Change Summary

• modified: bfd/ChangeLog
• modified: bfd/elf64-ppc.c

Incremental Difference

--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
[phone]  Alan Modra  <[e-mail]>
+
+	* elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.
+
 2020-01-15  Alan Modra  <[e-mail]>
 
 	PR 25384

--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -7158,7 +7158,7 @@ ppc64_elf_inline_plt (struct bfd_link_info *info)
 	      return FALSE;
 
 	    relend = relstart + sec->reloc_count;
-	    for (rel = relstart; rel < relend; )
+	    for (rel = relstart; rel < relend; rel++)
 	      {
 		enum elf_ppc64_reloc_type r_type;
 		unsigned long r_symndx;