Ticket #48792

is_<enum>_user_flag()

오픈 날짜: 2023-10-03 03:16 마지막 업데이트: 2024-05-29 18:36

Reporter:
소유자:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

Follow-up idea to #48790 : when specenum has user flags defined, specenum generator could output inline function "bool is_<enum>_user_flag(enum <enum>)"

This would also at least reduce the need for defining likes of TER_USER_LAST.

Ticket History (3/5 Histories)

2023-10-03 03:16 Updated by: cazfi
  • New Ticket "is_<enum>_user_flag()" created
2023-10-05 22:48 Updated by: alienvalkyrie
댓글 올리기

Seems reasonable. Short-term, adding new things now does mean that the code gets split between <file>_enums_gen.h and specenum_gen.h, but long-term, we'll want to phase out the latter anyway.

I'm not sure about the name, given that codegen-side, I called them "generic"; so I'd probably make it bool is_<enum>_generic(enum <enum>). Then again, we are only using them for user flags, so it could instead be reasonable to use that language codegen-side.

Depending on the use cases, we might want to have a bunch more general #defines; e.g. for the last generic value (like EF_LAST_USER_FLAG or TER_USER_LAST) or the total number of generic values (like MAX_NUM_USER_EXTRA/TER_FLAGS).

2024-05-27 21:20 Updated by: alienvalkyrie
  • 소유자 Update from (None) to alienvalkyrie
  • Resolution Update from None to Accepted
댓글 올리기

Made it so the name for the function is chosen on a per-enum basis (just like the names for the generic enum members are). So it can be is_foo_user_flag or is_user_foo_flag or is_foo_flag_user_flag or whatever would be appropriately in line with other code involving that specific enum.

2024-05-29 18:36 Updated by: alienvalkyrie
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login