Ticket #47392

homebrew-appbundle.sh: Set correct version number

오픈 날짜: 2023-02-18 10:55 마지막 업데이트: 2023-03-03 06:17

Reporter:
소유자:
Type:
Status:
Closed
Component:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

Noticed that homebrew-appbundle.sh sets hardcoded "3.1.0-alpha" version string to info file, regardless of the freeciv version.

Ticket History (3/6 Histories)

2023-02-18 10:55 Updated by: cazfi
  • New Ticket "homebrew-appbundle.sh: Set correct version number" created
2023-02-19 02:23 Updated by: cazfi
  • 소유자 Update from (None) to ddeanbrown
댓글 올리기

- Should be relatively easy to implement - just run fc_version from the source root to get the version
- Failing actual code update before 3.1.0-beta1, we need to adjust our release process (for that release) so that the hardcoded version numbers are set correctly

2023-02-28 12:23 Updated by: ddeanbrown
댓글 올리기

This patch should do it.

2023-02-28 19:49 Updated by: cazfi
  • 소유자 Update from ddeanbrown to cazfi
  • Resolution Update from None to Accepted
댓글 올리기

Thanks. But please try not to include unrelated changes to a patch in the future (here especially the gtk3.22-client -> gtk4-client switch - I'm inclined to just add mention of that to the commit message this time when I push this in, instead of rejecting the entire patch because of it)

2023-03-03 06:17 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Attachment File List

Edit

Please login to add comment to this ticket » Login