Fujii Masao
masao****@gmail*****
2015年 2月 2日 (月) 19:02:47 JST
On Thu, Jan 22, 2015 at 7:30 PM, Beena Emerson <memis****@gmail*****> wrote: > The code of pg_trgm has been modified since April 2014 and most of them were > to the trgm_regexp.c file and can be ignored. However, few other minor > changes can be made to the pg_bigm. > > Following is the list of commits in pg_trm which can be applied to pg_bigm. > > 1. > link: > https://github.com/postgres/postgres/commit/e7128e8dbb305059c30ec085461297e619bcbff4 > Commit Description: > Create function prototype as part of PG_FUNCTION_INFO_V1 macro > Patch 01_Remove_redundant_function_declaration.patch removes the redundant > function protottypes from files bigm_gin.c and bigm_op.c The old versions of PostgreSQL don't like this patch. When I compiled the patched pg_bigm with PostgreSQL 9.3, I got the following warnings. bigm_op.c:519: warning: no previous prototype for 'show_bigm' bigm_op.c:599: warning: no previous prototype for 'bigm_similarity' bigm_op.c:621: warning: no previous prototype for 'bigm_similarity_op' bigm_op.c:631: warning: no previous prototype for 'likequery' bigm_op.c:695: warning: no previous prototype for 'bigmtextcmp' bigm_gin.c:37: warning: no previous prototype for 'gin_extract_value_bigm' bigm_gin.c:71: warning: no previous prototype for 'gin_extract_query_bigm' bigm_gin.c:178: warning: no previous prototype for 'gin_bigm_consistent' bigm_gin.c:245: warning: no previous prototype for 'gin_bigm_compare_partial' bigm_gin.c:273: warning: no previous prototype for 'pg_gin_pending_stats' The original commit that you mentioned changed PG_FUNCTION_INFO_V1 macro so that it creates a function prototype, so the function prototypes from pg_trgm could be removed. But that change has not been applied to the old version of PostgreSQL Regards, -- Fujii Masao
Fork