Beena Emerson
memis****@gmail*****
2013年 9月 25日 (水) 23:04:26 JST
On Wed, Sep 25, 2013 at 7:21 PM, Fujii Masao <masao****@gmail*****> wrote: > On Wed, Sep 25, 2013 at 10:33 PM, Beena Emerson <memis****@gmail*****> > wrote: > > > > On Wed, Sep 25, 2013 at 6:55 PM, Fujii Masao <masao****@gmail*****> > wrote: > >> > >> > >> Hmm.. ISTM that we should do > >> > >> *recheck = bigm_enable_recheck; > >> > >> *after* the following codes. > >> > >> if (nkeys == 1) > >> *recheck = *((bool *) extra_data); > >> > > > > > > 201 *recheck = bigm_enable_recheck; > > 202 if (nkeys == 1) > > 203 *recheck = *((bool *) extra_data); > > > > The recheck variable is initialized before the check. > > Oh,.... on second thought, what about something like the following? > > *recheck = bigm_enable_recheck; > if (nkeys == 1 && bigm_enable_check) > *recheck = *((bool *) extra_data); > Yes, this seems better. I will check and post the patches tomorrow. Beena Emerson -------------- next part -------------- HTML$B$NE:IU%U%!%$%k$rJ]4I$7$^$7$?(B...다운로드
Fork