Amit Langote
amitl****@gmail*****
2013年 9月 11日 (水) 23:03:12 JST
On Wed, Aug 14, 2013 at 7:56 PM, Amit Langote <amitl****@gmail*****> wrote: > On Wed, Aug 14, 2013 at 7:20 PM, Beena Emerson <memis****@gmail*****> wrote: >> >> Hi, >> >> The add-regression-tests-v4.patch seems fine :-) >> >> But I was wondering, since the message size has been increased, the regression patch can now have tests including all 1000 rows so that it is similar to the pg_trgm tests? >> >> I also felt it would be better to include one bigm_similarity test which will produce the result 1. Eg: SELECT bigm_similarity('wow', 'wow'); >> pg_trgm has tests to produce results 0, 1, a decimal. The same tests have been used in pg_bigm patch, but none of them give result 1. So I feel we can add one. >> >> What do you think? >> > > That makes sense. Thanks! > Sorry for being the significant half of a deadlock. :-) I will update (including rebasing) the patch with your suggestions. Hopefully this or the next week. -- Amit Langote
Fork