Fujii Masao
masao****@gmail*****
2013年 10月 3日 (木) 10:56:07 JST
On Mon, Sep 30, 2013 at 12:34 PM, Amit Langote <amitl****@gmail*****> wrote: > On Mon, Sep 30, 2013 at 12:22 PM, Fujii Masao <masao****@gmail*****> wrote: >> On Sat, Sep 28, 2013 at 6:16 PM, Beena Emerson <memis****@gmail*****> wrote: >>> Please find attached the updated patch to rebase against the new HEAD and >>> also implements the comments I had given before. I extracted the similarity function code from the patch as the separate one so that we can more easily review and commit it. I'd like to work on this first. After committing it, I'd like to work on the remaining similarity search code. Attached patch just implements pg_bigm version of similarity function. This is in WIP yet. The description of bigm_similarity function must be added into the document. The regression test must be updated. While reviewing the similartiy function, I found that there is one big problem in bigm_similarity(). That is, bigm_similarity() is case-sensitive, but pg_trgm version of similarity function is not. Please see the following example: =# select similarity('wow', 'WOW'); similarity ------------ 1 (1 row) =# select bigm_similarity('wow', 'WOW'); bigm_similarity ----------------- 0 (1 row) Should we implement the *case-insensitive* bigm_similarity()? Regards, -- Fujii Masao -------------- next part -------------- $B%F%-%9%H7A<00J30$NE:IU%U%!%$%k$rJ]4I$7$^$7$?(B... $B%U%!%$%kL>(B: bigm_similarity_v1.patch $B7?(B: application/octet-stream $B%5%$%:(B: 2147 $B%P%$%H(B $B ＠ bL@(B: $BL5$7(B다운로드
Fork