Fujii Masao
masao****@gmail*****
2015年 8月 28日 (金) 18:41:55 JST
On Mon, Aug 24, 2015 at 3:09 PM, <ishii****@nttda*****> wrote: > Thank you for review. > I updated the patch. > >> > Changes from the last time: >> > ・Delete unnecessary "CREATE USER" >> > (We use "CREATE USER" only when we create normal user.) >> >> You can use SET ROLE and RESET ROLE command in order to do permission >> test, instead of adding textporter-close test. > > I fixed to use SET ROLE instead of textporter-close test. > >> > expected/ludia_funcs.out:789: trailing whitespace. >> > +\c euc_db >> > expected/ludia_funcs.out:795: trailing whitespace. >> > +\c contrib_regression >> > sql/ludia_funcs.sql:176: trailing whitespace. >> > +\c euc_db >> > sql/ludia_funcs.sql:180: trailing whitespace. >> > +\c contrib_regression >> >> There are some unnecessary trailing whitespaces in >> 000_ludia_funcs_regress.patch as follows. > > I fixed to delete unnecessary trailing whitespaces. > >> > $ patch -d. -p1 < >> > ../patch/ludia_funcs_regress_patch/001_ludia_funcs_regress_debug_opt >> io >> > n.patch >> > patching file Makefile >> > Hunk #1 FAILED at 33. >> > 1 out of 1 hunk FAILED -- saving rejects to file Makefile.rej >> I could not apply 001_ludia_funcs_regress_debug_option.patch >> successfully. >> >> It looks like both file debug_option.patch and textporter.patch have >> wrong prefix number each other. >> debug_options patch should be applied after textporter patch applied. > > I fixed the number. > ・000_ludia_funcs_regress.patch > ・001_ludia_funcs_regress_textporter.patch > ・002_ludia_funcs_regress_debug_option.patch Pushed the heavily modified version of this patch. I included the tests that I could understand it's worth doing in the committed patch. Could you check the committed patch? If you think that other tests need to be added or the existing tests need to be changed, please comment them. Regards, -- Fujii Masao
Fork