[Groonga-commit] droonga/droonga-engine at e6671f8 [master] Brush up descriptios of command line options based on the reference

Back to archive index

YUKI Hiroshi null+****@clear*****
Fri May 8 09:49:56 JST 2015


YUKI Hiroshi	2015-05-08 09:49:56 +0900 (Fri, 08 May 2015)

  New Revision: e6671f8d74779704bbdba7d25b1c3065680565d9
  https://github.com/droonga/droonga-engine/commit/e6671f8d74779704bbdba7d25b1c3065680565d9

  Message:
    Brush up descriptios of command line options based on the reference

  Modified files:
    bin/droonga-engine-absorb-data
    bin/droonga-engine-join
    bin/droonga-engine-unjoin
    lib/droonga/command/remote_command_base.rb

  Modified: bin/droonga-engine-absorb-data (+14 -14)
===================================================================
--- bin/droonga-engine-absorb-data    2015-04-30 17:30:11 +0900 (1365556)
+++ bin/droonga-engine-absorb-data    2015-05-08 09:49:56 +0900 (054b902)
@@ -83,46 +83,46 @@ module Droonga
       parser.version = Engine::VERSION
 
       parser.separator("")
-      parser.separator("Destination node:")
+      parser.separator("Destination:")
       parser.on("--host=HOST",
-                "Host name of the destination node.") do |host|
+                "Host name of the destination engine node to copy data.") do |host|
         options.host = host
       end
       parser.on("--port=PORT", Integer,
-                "Port number of the destination node.",
+                "Port number to communicate with the destination engine node.",
                 "(#{options.port})") do |port|
         options.port = port
       end
       parser.on("--tag=TAG", Integer,
-                "Tag name of the destination node.",
+                "Tag name to communicate with the destination engine node.",
                 "(#{options.tag})") do |tag|
         options.tag = tag
       end
       parser.on("--dataset=DATASET",
-                "Name of the destination dataset.",
+                "Name of the destination dataset for copying data.",
                 "(#{options.dataset})") do |dataset|
         options.dataset = dataset
       end
 
       parser.separator("")
-      parser.separator("Source node:")
+      parser.separator("Source:")
       parser.on("--source-host=HOST",
-                "Host name of the source node.",
+                "Host name of the soruce engine node to copy data.",
                 "(#{options.source_host})") do |host|
         options.source_host = host
       end
       parser.on("--source-port=PORT", Integer,
-                "Port number of the source node.",
+                "Port number to communicate with the soruce engine node.",
                 "(#{options.source_port})") do |host|
         options.source_host = host
       end
       parser.on("--source-tag=TAG",
-                "Tag name of the source node.",
+                "Tag name to communicate with the soruce engine node.",
                 "(#{options.source_tag})") do |tag|
         options.source_tag = tag
       end
       parser.on("--source-dataset=DATASET",
-                "Name of the source dataset.",
+                "Name of the soruce dataset for copying data.",
                 "(#{options.source_dataset})") do |dataset|
         options.source_dataset = dataset
       end
@@ -130,7 +130,7 @@ module Droonga
       parser.separator("")
       parser.separator("Connection:")
       parser.on("--receiver-host=HOST",
-                "Host name of this computer.",
+                "Host name of the computer you are running this command.",
                 "(#{options.receiver_host})") do |host|
         options.receiver_host = host
       end
@@ -138,18 +138,18 @@ module Droonga
       parser.separator("")
       parser.separator("Miscellaneous:")
       parser.on("--records-per-second=N", Integer,
-                "Maximum number of records per second to be absorbed.",
+                "Maximum number of records to be copied per one second.",
                 "'#{Client::RateLimiter::NO_LIMIT}' means no limit.",
                 "(#{options.messages_per_second})") do |n|
         options.messages_per_second = n
       end
       parser.on("--progress-interval-seconds=N", Integer,
-                "Interval seconds to report progress.",
+                "Interval seconds to report progress of data copying.",
                 "(#{options.progress_interval_seconds})") do |n|
         options.progress_interval_seconds = n
       end
       parser.on("--[no-]verbose",
-                "Output details for internal operations.",
+                "Output details for internal operations or not.",
                 "(#{options.verbose})") do |verbose|
         options.verbose = verbose
       end

  Modified: bin/droonga-engine-join (+8 -8)
===================================================================
--- bin/droonga-engine-join    2015-04-30 17:30:11 +0900 (97d3b34)
+++ bin/droonga-engine-join    2015-05-08 09:49:56 +0900 (021be4c)
@@ -92,7 +92,7 @@ module Droonga
     private
     def parse_options
       options = Slop.parse(:help => true) do |option|
-        option.on("no-copy", "Don't copy data from the source cluster.",
+        option.on("no-copy", "Don't copy data from the source node.",
                   :default => false)
 
         option.separator("Target:")
@@ -100,33 +100,33 @@ module Droonga
                   "Host name of the new node to be joined.",
                   :required => true)
         option.on("replica-source-host=",
-                  "Host name of the soruce node in the cluster to be connected.",
+                  "Host name of the soruce node in the cluster to join.",
                   :required => true)
 
         option.on(:port=,
-                  "Port number of the source cluster to be connected.",
+                  "Port number to communicate with engine nodes.",
                   :as => Integer,
                   :default => NodeName::DEFAULT_PORT)
         option.on(:tag=,
-                  "Tag name of the soruce cluster to be connected.",
+                  "Tag name to communicate with engine nodes.",
                   :default => NodeName::DEFAULT_TAG)
         option.on(:dataset=,
-                  "Dataset name of for the node to be joined.",
+                  "Dataset name the node is going to join as a replica in.",
                   :default => Catalog::Dataset::DEFAULT_NAME)
 
         option.separator("Connections:")
         option.on("receiver-host=",
-                  "Host name of this host.",
+                  "Host name of the computer you are running this command.",
                   :default => Socket.gethostname)
 
         option.separator("Miscellaneous:")
         option.on("records-per-second=",
-                  "Maximum number of records per second to be copied. " +
+                  "Maximum number of records to be copied per one second. " +
                     "'#{Client::RateLimiter::NO_LIMIT}' means no limit.",
                   :as => Integer,
                   :default => DataAbsorberClient::DEFAULT_MESSAGES_PER_SECOND)
         option.on("progress-interval-seconds=",
-                  "Interval seconds to report progress.",
+                  "Interval seconds to report progress of data copying.",
                   :as => Integer,
                   :default => DataAbsorberClient::DEFAULT_PROGRESS_INTERVAL_SECONDS)
         option.on(:verbose, "Output details for internal operations.",

  Modified: bin/droonga-engine-unjoin (+2 -2)
===================================================================
--- bin/droonga-engine-unjoin    2015-04-30 17:30:11 +0900 (fd8787c)
+++ bin/droonga-engine-unjoin    2015-05-08 09:49:56 +0900 (0702eb9)
@@ -31,10 +31,10 @@ module Droonga
       def run
         parse_options do |option|
           option.on("receiver-host=",
-                    "Host name of this host.",
+                    "Host name of the computer you are running this command.",
                     :default => Socket.gethostname)
           option.on(:dataset=,
-                    "Dataset name of for the node to be unjoined.",
+                    "Dataset name the node is going to be removed from.",
                     :default => Catalog::Dataset::DEFAULT_NAME)
         end
 

  Modified: lib/droonga/command/remote_command_base.rb (+3 -3)
===================================================================
--- lib/droonga/command/remote_command_base.rb    2015-04-30 17:30:11 +0900 (896126f)
+++ lib/droonga/command/remote_command_base.rb    2015-05-08 09:49:56 +0900 (4b21a40)
@@ -31,14 +31,14 @@ module Droonga
 
           option.separator("Connections:")
           option.on(:host=,
-                    "Host name of the target node.",
+                    "Host name of the node to be operated.",
                     :required => true)
           option.on(:port=,
-                    "Port number of the source cluster to be connected.",
+                    "Port number to communicate with the engine node.",
                     :as => Integer,
                     :default => NodeName::DEFAULT_PORT)
           option.on(:tag=,
-                    "Tag name of the soruce cluster to be connected.",
+                    "Tag name to communicate with the engine node.",
                     :default => NodeName::DEFAULT_TAG)
 
           option.separator("Miscellaneous:")
-------------- next part --------------
HTML����������������������������...
다운로드 



More information about the Groonga-commit mailing list
Back to archive index