[Groonga-commit] droonga/droonga-engine at de8e8ca [master] Revert "Add codes to restart workers after schema change (WIP)"

Back to archive index

YUKI Hiroshi null+****@clear*****
Thu Oct 9 14:48:37 JST 2014


YUKI Hiroshi	2014-10-09 14:48:37 +0900 (Thu, 09 Oct 2014)

  New Revision: de8e8ca3b437cc94be745d4b316a8d501875e08c
  https://github.com/droonga/droonga-engine/commit/de8e8ca3b437cc94be745d4b316a8d501875e08c

  Message:
    Revert "Add codes to restart workers after schema change (WIP)"
    
    This reverts commit 9f03f9a01ba753fea10d92c66a2a8690910d0b68.
    It should not be done by commands.

  Modified files:
    lib/droonga/plugins/groonga/column_create.rb
    lib/droonga/plugins/groonga/column_remove.rb
    lib/droonga/plugins/groonga/column_rename.rb
    lib/droonga/plugins/groonga/generic_command.rb
    lib/droonga/plugins/groonga/table_create.rb
    lib/droonga/plugins/groonga/table_remove.rb

  Modified: lib/droonga/plugins/groonga/column_create.rb (+2 -5)
===================================================================
--- lib/droonga/plugins/groonga/column_create.rb    2014-10-09 14:48:28 +0900 (a9e73d3)
+++ lib/droonga/plugins/groonga/column_create.rb    2014-10-09 14:48:37 +0900 (266b870)
@@ -29,14 +29,11 @@ module Droonga
 
             table_name = valid_table_name("table", :error_result => false)
 
-            result = false
             if****@comma*****_index?
-              result = define_index(table_name)
+              define_index(table_name)
             else
-              result = define_column(table_name)
+              define_column(table_name)
             end
-            restart_workers
-            result
           end
 
           private

  Modified: lib/droonga/plugins/groonga/column_remove.rb (+1 -3)
===================================================================
--- lib/droonga/plugins/groonga/column_remove.rb    2014-10-09 14:48:28 +0900 (48ebbf6)
+++ lib/droonga/plugins/groonga/column_remove.rb    2014-10-09 14:48:37 +0900 (9ee130e)
@@ -31,9 +31,7 @@ module Droonga
             column_name = valid_column_name("name", :table_name => table_name,
                                                     :error_result => false)
 
-            result = remove_column(table_name, column_name)
-            restart_workers
-            result
+            remove_column(table_name, column_name)
           end
 
           private

  Modified: lib/droonga/plugins/groonga/column_rename.rb (+1 -3)
===================================================================
--- lib/droonga/plugins/groonga/column_rename.rb    2014-10-09 14:48:28 +0900 (600a66a)
+++ lib/droonga/plugins/groonga/column_rename.rb    2014-10-09 14:48:37 +0900 (fad8a04)
@@ -33,9 +33,7 @@ module Droonga
 
             new_name = @command["new_name"]
 
-            result = rename_column(table_name, column_name, new_name)
-            restart_workers
-            result
+            rename_column(table_name, column_name, new_name)
           end
 
           private

  Modified: lib/droonga/plugins/groonga/generic_command.rb (+0 -4)
===================================================================
--- lib/droonga/plugins/groonga/generic_command.rb    2014-10-09 14:48:28 +0900 (c9938a6)
+++ lib/droonga/plugins/groonga/generic_command.rb    2014-10-09 14:48:37 +0900 (ef67706)
@@ -102,10 +102,6 @@ module Droonga
 
           column_name
         end
-
-        def restart_workers
-          #XXX IMPLEMENT ME!!
-        end
       end
     end
   end

  Modified: lib/droonga/plugins/groonga/table_create.rb (+0 -1)
===================================================================
--- lib/droonga/plugins/groonga/table_create.rb    2014-10-09 14:48:28 +0900 (e48dd78)
+++ lib/droonga/plugins/groonga/table_create.rb    2014-10-09 14:48:37 +0900 (05c8154)
@@ -39,7 +39,6 @@ module Droonga
             ::Groonga::Schema.define(:context => @context) do |schema|
               schema.create_table(name, options)
             end
-            restart_workers
             true
           end
 

  Modified: lib/droonga/plugins/groonga/table_remove.rb (+0 -1)
===================================================================
--- lib/droonga/plugins/groonga/table_remove.rb    2014-10-09 14:48:28 +0900 (f46d621)
+++ lib/droonga/plugins/groonga/table_remove.rb    2014-10-09 14:48:37 +0900 (59b51e4)
@@ -32,7 +32,6 @@ module Droonga
             ::Groonga::Schema.define(:context => @context) do |schema|
               schema.remove_table(name)
             end
-            restart_workers
             true
           end
         end
-------------- next part --------------
HTML����������������������������...
다운로드 



More information about the Groonga-commit mailing list
Back to archive index