[Groonga-commit] groonga/grnxx at 3f1afe3 [master] Disable specialization for sorting records in score order. (#119)

Back to archive index

susumu.yata null+****@clear*****
Tue Dec 16 10:53:39 JST 2014


susumu.yata	2014-11-27 00:04:00 +0900 (Thu, 27 Nov 2014)

  New Revision: 3f1afe38423ba2e12b8396ed05c36cd624ce47df
  https://github.com/groonga/grnxx/commit/3f1afe38423ba2e12b8396ed05c36cd624ce47df

  Message:
    Disable specialization for sorting records in score order. (#119)

  Modified files:
    lib/grnxx/impl/sorter.cpp

  Modified: lib/grnxx/impl/sorter.cpp (+7 -5)
===================================================================
--- lib/grnxx/impl/sorter.cpp    2014-11-27 00:00:41 +0900 (8f6bfda)
+++ lib/grnxx/impl/sorter.cpp    2014-11-27 00:04:00 +0900 (f7bb15f)
@@ -1129,11 +1129,13 @@ Node *Sorter::create_node(SorterOrder &&order) try {
       return new RowIDNode<ReverseRowIDComparer>(std::move(order));
     }
   } else if (order.expression->is_score()) {
-    if (order.type == SORTER_REGULAR_ORDER) {
-      return new ScoreNode<RegularScoreComparer>(std::move(order));
-    } else {
-      return new ScoreNode<ReverseScoreComparer>(std::move(order));
-    }
+    // NOTE: Specialization for Score is disabled because the implementation
+    //       showed poor performance.
+//    if (order.type == SORTER_REGULAR_ORDER) {
+//      return new ScoreNode<RegularScoreComparer>(std::move(order));
+//    } else {
+//      return new ScoreNode<ReverseScoreComparer>(std::move(order));
+//    }
   }
 
   switch (order.expression->data_type()) {
-------------- next part --------------
HTML����������������������������...
다운로드 



More information about the Groonga-commit mailing list
Back to archive index