susumu.yata
null+****@clear*****
Fri Mar 22 12:58:39 JST 2013
susumu.yata 2013-03-22 12:58:39 +0900 (Fri, 22 Mar 2013) New Revision: 1ff3ce6e1126464076c9cea6da547a4876902b74 https://github.com/groonga/grnxx/commit/1ff3ce6e1126464076c9cea6da547a4876902b74 Message: Add TODOs. Modified files: lib/map/da/basic/key_cursor.cpp lib/map/da/basic/predictive_cursor.cpp Modified: lib/map/da/basic/key_cursor.cpp (+4 -0) =================================================================== --- lib/map/da/basic/key_cursor.cpp 2013-03-22 11:06:47 +0900 (c5bea0b) +++ lib/map/da/basic/key_cursor.cpp 2013-03-22 12:58:39 +0900 (040a16e) @@ -70,6 +70,7 @@ void KeyCursor::open_cursor(Trie *trie, MapCursorFlags flags, } } +// TODO: std::vector::push_back() may throw an exception. void KeyCursor::ascending_init(const Slice &min, const Slice &max) { if (max) { has_end_ = true; @@ -138,6 +139,7 @@ void KeyCursor::ascending_init(const Slice &min, const Slice &max) { } } +// TODO: std::vector::push_back() may throw an exception. void KeyCursor::descending_init(const Slice &min, const Slice &max) { if (min) { has_end_ = true; @@ -199,6 +201,7 @@ void KeyCursor::descending_init(const Slice &min, const Slice &max) { } } +// TODO: std::vector::push_back() may throw an exception. bool KeyCursor::ascending_next() { while (!node_ids_.empty()) { const uint64_t node_id = node_ids_.back(); @@ -235,6 +238,7 @@ bool KeyCursor::ascending_next() { return false; } +// TODO: std::vector::push_back() may throw an exception. bool KeyCursor::descending_next() { while (!node_ids_.empty()) { const bool post_order = node_ids_.back() & POST_ORDER_FLAG; Modified: lib/map/da/basic/predictive_cursor.cpp (+1 -1) =================================================================== --- lib/map/da/basic/predictive_cursor.cpp 2013-03-22 11:06:47 +0900 (87ffc41) +++ lib/map/da/basic/predictive_cursor.cpp 2013-03-22 12:58:39 +0900 (503cd13) @@ -154,7 +154,7 @@ bool PredictiveCursor::descending_next() try { } } else { node_ids_.back() |= POST_ORDER_FLAG; - uint64_t label = trie_->nodes_[node_id].child(); + uint16_t label = trie_->nodes_[node_id].child(); while (label != INVALID_LABEL) { node_ids_.push_back(node.offset() ^ label); label = trie_->nodes_[node.offset() ^ label].sibling(); -------------- next part -------------- HTML����������������������������...다운로드
