[Groonga-commit] ranguba/rroonga at e5fe024 [master] Groonga::Expression#append_constant supports operator name

Back to archive index

Kouhei Sutou null+****@clear*****
Tue Dec 24 22:47:10 JST 2013


Kouhei Sutou	2013-12-24 22:47:10 +0900 (Tue, 24 Dec 2013)

  New Revision: e5fe024f3564a4f282df31e03f4475dbd42ada89
  https://github.com/ranguba/rroonga/commit/e5fe024f3564a4f282df31e03f4475dbd42ada89

  Message:
    Groonga::Expression#append_constant supports operator name

  Modified files:
    ext/groonga/rb-grn-expression.c
    test/test-expression.rb

  Modified: ext/groonga/rb-grn-expression.c (+1 -1)
===================================================================
--- ext/groonga/rb-grn-expression.c    2013-12-24 22:44:30 +0900 (7444f08)
+++ ext/groonga/rb-grn-expression.c    2013-12-24 22:47:10 +0900 (9b713e0)
@@ -222,7 +222,7 @@ rb_grn_expression_append_constant (int argc, VALUE *argv, VALUE self)
 
     rb_scan_args(argc, argv, "12", &rb_constant, &rb_operator, &rb_n_arguments);
     if (!NIL_P(rb_operator))
-        operator = NUM2INT(rb_operator);
+        operator = RVAL2GRNOPERATOR(rb_operator);
     if (!NIL_P(rb_n_arguments))
         n_arguments = NUM2INT(rb_n_arguments);
 

  Modified: test/test-expression.rb (+21 -0)
===================================================================
--- test/test-expression.rb    2013-12-24 22:44:30 +0900 (337e1a0)
+++ test/test-expression.rb    2013-12-24 22:47:10 +0900 (860bfe9)
@@ -132,6 +132,27 @@ class ExpressionTest < Test::Unit::TestCase
     snippet.close
   end
 
+  class AppendConstantTest < self
+    setup
+    def setup_expression
+      @expression = Groonga::Expression.new
+    end
+
+    class OperatorTest < self
+      def test_constant
+        @expression.append_constant(29, Groonga::Operator::PUSH, 1)
+        assert_equal("#<Groonga::Expression noname(){029}>",
+                     @expression.inspect)
+      end
+
+      def test_name
+        @expression.append_constant(29, "push", 1)
+        assert_equal("#<Groonga::Expression noname(){029}>",
+                     @expression.inspect)
+      end
+    end
+  end
+
   class AppendOperatorTest < self
     setup
     def setup_expression
-------------- next part --------------
HTML����������������������������...
다운로드 



More information about the Groonga-commit mailing list
Back to archive index