groonga/gcs [master] Don't compare null with object (Groonga-commit) - Groonga - fulltext search engine.

SHIMODA Hiroshi	2012-08-14 18:44:33 +0900 (Tue, 14 Aug 2012)

  New Revision: ffc37d6a85c00f3ff81605bb9035dcbdf3ffa966
  https://github.com/groonga/gcs/commit/ffc37d6a85c00f3ff81605bb9035dcbdf3ffa966

  Log:
    Don't compare null with object

  Modified files:
    test/database-domain.test.js
    test/database-index-field.test.js

  Modified: test/database-domain.test.js (+10 -5)
===================================================================

--- test/database-domain.test.js    2012-08-14 18:41:08 +0900 (744e196)
+++ test/database-domain.test.js    2012-08-14 18:44:33 +0900 (7ff2ada)
@@ -258,7 +258,8 @@ suite('database', function() {
     });
 
     test('setting default search field (instance)', function() {
-      assert.equal(domain.defaultSearchField, null);
+      assert.isTrue(domain.defaultSearchField === null,
+                    domain.defaultSearchField);
       var nameField = domain.getIndexField('name');
       domain.defaultSearchField = nameField;
       assert.equal(domain.defaultSearchField, nameField);
@@ -269,7 +270,8 @@ suite('database', function() {
     });
 
     test('setting default search field (text)', function() {
-      assert.equal(domain.defaultSearchField, null);
+      assert.isTrue(domain.defaultSearchField === null,
+                    domain.defaultSearchField);
       domain.defaultSearchField = 'name';
       assert.equal(domain.defaultSearchField, domain.getIndexField('name'));
 
@@ -279,9 +281,11 @@ suite('database', function() {
     });
 
     test('setting default search field (unknown field)', function() {
-      assert.equal(domain.defaultSearchField, null);
+      assert.isTrue(domain.defaultSearchField === null,
+                    domain.defaultSearchField);
       domain.defaultSearchField = 'unknown';
-      assert.equal(domain.defaultSearchField, null);
+      assert.isTrue(domain.defaultSearchField === null,
+                    domain.defaultSearchField);
     });
 
     test('removing default search field', function() {
@@ -290,7 +294,8 @@ suite('database', function() {
       assert.equal(domain.defaultSearchField, nameField);
 
       domain.defaultSearchField = null;
-      assert.equal(domain.defaultSearchField, null);
+      assert.isTrue(domain.defaultSearchField === null,
+                    domain.defaultSearchField);
 
       var anotherDomainInstance = new Domain('companies', context);
       assert.equal(anotherDomainInstance.defaultSearchField, null);

  Modified: test/database-index-field.test.js (+4 -2)
===================================================================
--- test/database-index-field.test.js    2012-08-14 18:41:08 +0900 (f455c96)
+++ test/database-index-field.test.js    2012-08-14 18:44:33 +0900 (ffd3403)
@@ -302,7 +302,8 @@ suite('database', function() {
 
         field.defaultSearchField = true;
         field.saveOptionsSync();
-        assert.equal(domain.defaultSearchField, null);
+        assert.isTrue(domain.defaultSearchField === null,
+                      domain.defaultSearchField);
       });
 
       test('auto-remove default search field', function() {
@@ -314,7 +315,8 @@ suite('database', function() {
                      domain.getIndexField('product'));
 
         field.deleteSync();
-        assert.equal(domain.defaultSearchField, null);
+        assert.isTrue(domain.defaultSearchField === null,
+                      domain.defaultSearchField);
       });
     });
 
-------------- next part --------------
HTML����������������������������...
다운로드 


Groonga - fulltext search engine.

[Groonga-commit] groonga/gcs [master] Don't compare null with object