Uninitialized gives_shared_tiles on network protocol

• Reporter: cazfi
• 소유자: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

Running valgrind on S3_2 server side, sending to observer client:

==1573584== Conditional jump or move depends on uninitialised value(s)
==1573584==    at 0x3D8E90: bv_are_equal (bitvector.c:258)
==1573584==    by 0x377F91: send_packet_player_info_100 (packets_gen.c:23151)
==1573584==    by 0x1D46BF: send_player_info_c_real (plrhand.c:1179)
==1573584==    by 0x1BDD5F: connection_attach_real (connecthand.c:701)
==1573584==    by 0x1BF509: establish_new_connection (connecthand.c:273)
==1573584==    by 0x1BFD90: handle_login_request (connecthand.c:517)
==1573584==    by 0x204C47: incoming_client_packets (sernet.c:498)
==1573584==    by 0x204C47: server_sniff_all_input (sernet.c:902)
==1573584==    by 0x158CA4: srv_main (srv_main.c:3530)
==1573584==    by 0x14E25D: main (civserver.c:388)

packets_gen.c:23151 :

  differ = !BV_ARE_EQUAL(old->gives_shared_tiles, real_packet->gives_shared_tiles);

Ticket History (3/5 Histories)

2023-05-31 20:56 Updated by: cazfi

• New Ticket "Uninitialized shared_tiles on network protocol" created

2023-05-31 20:57 Updated by: cazfi

• Summary Updated

2023-06-12 11:14 Updated by: cazfi

• File 0039-Protocol-Fix-sending-gives_shared_tiles.patch (File ID: 12649) is attached

2023-06-12 11:14 Updated by: cazfi

• 소유자 Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-06-19 11:59 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed