ap_diplomat_battle() nonnull target_tile

• Reporter: cazfi
• 소유자: cazfi
• Type: Bugs
• Status: Closed
• Component: General
• MileStone: 3.0.8 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 3

Details

Seen on S3_0; clang analyzer gives warnings about NULL dereference with tgt_tile parameter of ap_diplomat_battle().

Should probably make it nonnull, and see what further issues that reveals.

Ticket History (3/6 Histories)

2023-05-24 20:32 Updated by: cazfi

• New Ticket "ap_diplomat_battle() nonnull target_tile" created

2023-05-27 05:19 Updated by: cazfi

• File 0016-Add-nonnull-attribute-to-ap_diplomat_battle-tgt_tile.patch (File ID: 12484) is attached

2023-05-27 05:20 Updated by: cazfi

• File 0009-Add-nonnull-attribute-to-ap_diplomat_battle-tgt_tile.patch (File ID: 12485) is attached

2023-05-27 05:20 Updated by: cazfi

• File 0005-Fix-ap_diplomat_battle-clang-analyzer-warnings.patch (File ID: 12486) is attached

2023-05-27 05:21 Updated by: cazfi

• 소유자 Update from (None) to cazfi
• Resolution Update from None to Accepted

댓글 올리기

Reply To cazfi

Should probably make it nonnull, and see what further issues that reveals.

S3_1 - main were not affected, but the "nonnull attribute" part done in attached patches anyway. S3_0 patch has more comprehensive fix.

2023-05-29 13:05 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed