load/save is not idempotent

• Reporter: alain_bkr
• 소유자: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.1.2 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 4

Details

origin/S3_1 373049274 HEAD 7ef4e956f (+6)

I loaded a saved game then save it, with or without threaded save.

The first load/save is not idempotent : the saved files contains different things, 74 lines for the diff file , notably

< random_seed=30659428
80c78
< last_turn_change_time=1
---
> last_turn_change_time=0
99a98
> code=$$
227d225
< random_seed=2067455005

and

3641c3653
< turn=627
---
> turn=-2

Ticket History (3/12 Histories)

2023-05-04 19:50 Updated by: alain_bkr

• New Ticket "load/save is not idempotent" created

2023-05-04 19:51 Updated by: alain_bkr

• File Sz1-Ai001-Lm45-230503_154054-T00629-auto.sav.xz (File ID: 12337) is attached

2023-05-04 19:52 Updated by: alain_bkr

• File load_save.diff (File ID: 12338) is attached

2023-05-04 19:57 Updated by: alain_bkr

• File manual1.sav.xz (File ID: 12339) is attached

2023-05-28 02:46 Updated by: cazfi

댓글 올리기

That's basically #44736

2023-06-03 03:05 Updated by: alain_bkr

댓글 올리기

This is a part of #44736.

Multiple load/save without playing should produce the same saved file .

ti seems to be a requirement before reaching #44736 which may need to save additional informations.

2023-09-06 02:54 Updated by: cazfi

• Milestone Update from (None) to S3_2 d3f (closed)

2024-05-03 19:47 Updated by: cazfi

댓글 올리기

Split the history.turn part to https://redmine.freeciv.org/issues/530

2024-05-04 05:42 Updated by: cazfi

댓글 올리기

last_turn_change_time -> https://redmine.freeciv.org/issues/545

2024-05-09 23:46 Updated by: cazfi

• File 0072-Savegame-Load-map-random-seed.patch (File ID: 13751) is attached

2024-05-09 23:48 Updated by: cazfi

• 소유자 Update from (None) to cazfi
• Resolution Update from None to Accepted
• Milestone Update from S3_2 d3f (closed) to 3.1.2 (closed)

댓글 올리기

Patch for the map.random_seed attached. I guess that's the last part we can get out from this savegame example.

2024-05-29 18:18 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed