sdl2: Dead 'pBuf' assignment in popup_hurry_production_dialog()

• Reporter: cazfi
• 소유자: cazfi
• Type: Bugs
• Status: Closed
• Component: SDL2-client
• MileStone: 3.0.8 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

As reported by clang analyzer, S3_1 popup_hurry_production_dialog() has assignment 'pBuf = pWindow->prev;' twice so that pBuf is not used at all in between. I also think that 'pWindow->prev' cannot change between those assignments, but have not checked carefully.

Ticket History (3/7 Histories)

2023-04-13 10:53 Updated by: cazfi

• New Ticket "sdl2: Dead 'pBuf' assignment in popup_hurry_production_dialog()" created

2023-04-13 11:08 Updated by: cazfi

• File 0024-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12172) is attached

2023-04-13 11:09 Updated by: cazfi

• File 0024-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12173) is attached

2023-04-13 11:09 Updated by: cazfi

• File 0024-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12172) is deleted

2023-04-13 11:09 Updated by: cazfi

• File 0033-sdl2-Fix-dead-pBuf-assignment-in-popup_hurry_product.patch (File ID: 12174) is attached

2023-04-13 11:09 Updated by: cazfi

• 소유자 Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-04-22 01:13 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed