tileset_setup_unit_direction() expects unit_activity_name(ACTIVITY_LAST) to be valid string

• Reporter: cazfi
• 소유자: cazfi
• Type: Bugs
• Status: Closed
• Component: Client common
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

Even when called with ACTIVITY_LAST, tileset_setup_unit_direction() does:

--

fc_snprintf(buf, sizeof(buf), "%s_%s_%s", base_str,

unit_activity_name(activity),
dir_get_tileset_name(loaddir));

Ticket History (3/5 Histories)

2023-01-07 00:10 Updated by: cazfi

• New Ticket "tileset_setup_unit_direction() expects unit_activity_name(ACTIVITY_LAST) to be valid string" created

2023-01-07 00:16 Updated by: cazfi

댓글 올리기

Though it's not possible to end there with such illegal activity, heuristics of a bit older gcc (seen on Ubuntu Focal) fail to find that out, and give a warning.

2023-01-07 01:11 Updated by: cazfi

• File 0040-tileset_setup_unit_direction-Fix-gcc-9-warning.patch (File ID: 11323) is attached

2023-01-07 01:11 Updated by: cazfi

• 소유자 Update from (None) to cazfi
• Resolution Update from None to Accepted

2023-01-12 03:31 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed