@cazfi
- Remove also the loading part.
- The compat change should be one to silence "unused entry" -warning (try to run with --warnings) when the loading part is removed from the savegame3.c: likely just "(void) secfile_entry_lookup(...)"
Reply To cazfi
- Remove also the loading part.
- The compat change should be one to silence "unused entry" -warning (try to run with --warnings) when the loading part is removed from the savegame3.c: likely just "(void) secfile_entry_lookup(...)"
Hi. I am nowhere. I cannot found if there is a still loading part. I search for hardcoded counters in savegame3.c.
Reply To lachu
I am nowhere. I cannot found if there is a still loading part. I search for hardcoded counters in savegame3.c.
Right, There wasn't. That actually was how I encountered the problem - I got the "unused entry" warning as the entry is never loaded. So; we need to stop saving the field to new savegames (your patch already did that) and to silence the warning with secfile_entry_lookup() while loading those savegames where it was saved to.
Reply To cazfi
Reply To lachu
I am nowhere. I cannot found if there is a still loading part. I search for hardcoded counters in savegame3.c.
Right, There wasn't. That actually was how I encountered the problem - I got the "unused entry" warning as the entry is never loaded. So; we need to stop saving the field to new savegames (your patch already did that) and to silence the warning with secfile_entry_lookup() while loading those savegames where it was saved to.
This should work as expected.
Looks good, but does not apply to master HEAD.
Reply To cazfi
Looks good, but does not apply to master HEAD.
Counters are no longer hardcoded, so we should not save "game.hardcoded_counters" any more and especially not as TRUE!
The "unused entry" warning should be silenced from dev savegames (in "< 3019300" block of compat_load_dev() )