fc_strrep_resize() not working on NDEBUG build
fc_strrep_resize() has:
#ifndef FREECIV_NDEBUG bool success = fc_strrep(str, (*len), search, replace); #endif
The purpose has (clearly?) been to not have 'success' variable in NDEBUG build, but the fc_strrep() call should still be made for its side effects.
fc_strrep_resize() is used only by freeciv-manual. The kind of people who use freeciv-manual are unlikely to be using NDEBUG builds, so I think actual impact of this bug to be really minor.
fc_strrep_resize() has:
#ifndef FREECIV_NDEBUG
bool success = fc_strrep(str, (*len), search, replace);
#endif
The purpose has (clearly?) been to not have 'success' variable in NDEBUG build, but the fc_strrep() call should still be made for its side effects.