generate_packets.py: Generated code call 'are_cm_parameters_equal()'

• Reporter: cazfi
• 소유자: cazfi
• Type: Bugs
• Status: Closed
• Component: General
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

When a packet definition containing cm_parameter is added to packets.def (there isn't any at the moment), compile fails for are_cm_parameters_equal() calls in packets_gen.c. I guess it should be cm_are_parameters_equal()

Ticket History (3/7 Histories)

2022-07-29 23:45 Updated by: cazfi

• New Ticket "generate_packets.py: Generated code call 'are_cm_parameters_equal()'" created

2022-07-30 00:02 Updated by: cazfi

댓글 올리기

Reply To cazfi

When a packet definition containing cm_parameter is added to packets.def

Example is in WIP patch attached to #45268

2022-07-30 18:05 Updated by: alienvalkyrie

• File 0002-generate_packets.py-Correctly-identify-cm_parameter-.patch (File ID: 9987) is attached

2022-07-30 18:08 Updated by: alienvalkyrie

댓글 올리기

Typo in the generate_packets type parsing code. I'm a bit busy, so I haven't tested the patch in action, but it should work. If not, I'll have to take a closer look.

(Edited, 2022-07-30 18:08 Updated by: alienvalkyrie)

2022-08-17 17:52 Updated by: cazfi

• Milestone Update from (None) to 3.2.0

댓글 올리기

It works.

2022-08-22 10:22 Updated by: cazfi

• 소유자 Update from (None) to cazfi
• Resolution Update from None to Accepted

2022-08-23 23:59 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed