Garbage defender in send_combat()

• Reporter: cazfi
• 소유자: cazfi
• Type: Bugs
• Status: Closed
• Component: Server
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

I'm looking at map_get_seen() segfault with the new fantasy ruleset. So far it seems that pdefender in send_combat() is garbage pointer (or at least it points to garbage content), which then leads to garbage playermap pointer to access seen counters.

Ticket History (3/6 Histories)

2022-07-26 19:27 Updated by: cazfi

• New Ticket "Garbage defender in send_combat()" created

2022-07-26 19:52 Updated by: cazfi

댓글 올리기

It seems that unit_attack_civilian_casualties() call causes the city to get destroyed, taking supported units with it, and the failed defender was one of those.

2022-07-26 19:55 Updated by: cazfi

• Milestone Update from (None) to 3.2.0
• Component Update from (None) to Server

댓글 올리기

Only master affected, as older branches do not reduce city size in case it's already 1, i.e., city never gets destroyed in that call.

2022-08-01 12:36 Updated by: cazfi

• File 0057-do_attack-Shrink-city-only-after-complete-removal-of.patch (File ID: 9993) is attached

2022-08-01 12:36 Updated by: cazfi

• 소유자 Update from (None) to cazfi
• Resolution Update from None to Accepted

2022-08-10 15:26 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed