generate_packets.py: make files_equal() compare contents line by line

• Reporter: alienvalkyrie
• 소유자: alienvalkyrie
• Type: Patches
• Status: Closed
• Component: Bootstrap
• MileStone: 3.2.0
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 1

Details

Part of #43927. Related to #45186. The files_equal() helper function (which is used by lazy-overwrite) currently loads both input files completely ~> make it use the fact that TextIO objects are iterable to compare them line by line

Ticket History (3/4 Histories)

2022-07-22 00:23 Updated by: alienvalkyrie

• New Ticket "generate_packets.py: make files_equal() compare contents line by line" created

2022-07-22 00:43 Updated by: alienvalkyrie

• File 0004-generate_packets.py-make-files_equal-compare-lines.patch (File ID: 9895) is attached

2022-07-22 00:46 Updated by: alienvalkyrie

• Resolution Update from None to Accepted

댓글 올리기

Depends on #45186 (or rather, its parts):

• textual dependency on #45188 (import changes)
• this patch removes the now-unused read_text() function and thus must not be merged before #45189

2022-07-23 19:18 Updated by: alienvalkyrie

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed