Ticket #44611

Optimize some heavy MAX() and MIN() uses

오픈 날짜: 2022-05-15 15:02 마지막 업데이트: 2022-07-05 04:55

Reporter:
소유자:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
3

Details

We have some MAX() and MIN() uses where one of the parameters is relatively heavy to evaluate AND such that the compiler cannot optimize away the need to do the full evaluation twice (a function call of which compiler does not know that it will return the same value both times, and has no side-effects)

Move such heavy evaluations outside the macros, to do them only once.

Ticket History (3/7 Histories)

2022-05-15 15:02 Updated by: cazfi
  • New Ticket "Optimize some heavy MAX() and MIN() uses" created
2022-05-29 06:46 Updated by: cazfi
2022-06-26 20:22 Updated by: cazfi
  • 소유자 Update from (None) to cazfi
  • Resolution Update from None to Accepted
댓글 올리기

For master I went through all MAX() and MIN() uses for candidates to change. For older branches I just ported those same changes, not checking if there would be additional candidates in them - except for porting gtk3.22-client changes to older gtk-clients supported only in older branches.

2022-07-05 04:55 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login