Ticket #44382

Team number confusion

오픈 날짜: 2022-04-15 11:58 마지막 업데이트: 2022-05-20 00:27

Reporter:
소유자:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

3.0.1 qt & gtk client, single player


1 Start client, new game, civ2 ruleset, set Number of Players to 5
2 Assign nations - American team 1, Babylonian team 2, Celtic team 3, English team 4, French team 5
3 Right click on Celtic, assign to team 2, observe that team 3 no longer appears - this may be where the problem starts
4 Right click on French, can't assign to team 3, assign to team 4, start the game, observe in F3 we have teams 1, 2 & 4
5 build American city, couple of new turns so other nations build a city
6 in edit mode, find French city and give it the Great Library
7 give Babylonian the Alphabet and Bronze, which also gives it to Celtic
8 give American the Alphabet and Bronze, give American city Marco Polo's Embassy
9 exit edit mode, new turn, get embassy with everyone
10 new turn, get message "The members of Team 3 have acquired (Alphabet or Bronze) from the Great Library"

Guessing that the server thinks French is team 3, and client thinks French is team 4

Ticket History (3/13 Histories)

2022-04-15 11:58 Updated by: ddeanbrown
  • New Ticket "Team number confusion" created
2022-04-15 11:59 Updated by: ddeanbrown
  • Component Update from (None) to Client common
2022-04-15 14:24 Updated by: cazfi
댓글 올리기

Unlikely, but there's also a small chance that there's a confusion with the generated team names. Would be nice to know if this only happens with these generated "Team <number>" names or also with rulesets defining names like "Red" / "Blue" / "Green"

2022-04-30 06:22 Updated by: alain_bkr
댓글 올리기

Team number are off-by-one in the messages in gtk-3.22. (i suppose the first team is 0 in server and 1 in client or something like this.)

2022-05-02 15:54 Updated by: cazfi
댓글 올리기

Actually, this is likely to be confusion between team names and team numbers, when the team names have originally been generated using numbers.

After step (3) you have teams named "Team 1", "Team 2", "Team 4", "Team 5", but numbered first, second, third, and fourth.

2022-05-02 16:41 Updated by: cazfi
댓글 올리기

Reply To ddeanbrown


10 new turn, get message "The members of Team 3 have acquired (Alphabet or Bronze) from the Great Library"

Hmm... I think you mean "team 3", and here the case makes a huge difference. "team 3" is a string generated from the current team number, "Team 3" would be full team name (originally generated as well, but at different time, by different function).

At least that would make sense reading of the bug when reading the source code; "team 3" would be the same as "Team 4"

2022-05-02 16:45 Updated by: cazfi
  • 소유자 Update from (None) to cazfi
  • Milestone Update from (None) to 3.0.2 (closed)
  • Component Update from Client common to General
2022-05-04 02:24 Updated by: alain_bkr
댓글 올리기

I found another example with 3.0.1 gtk3.22 :

  • In F7 , wonder report, me = team 0
  • In F8, cities reports , me = team 0
  • In F3 , nation report , me = Team 1

I end doubting who i am :)

2022-05-04 03:29 Updated by: ddeanbrown
댓글 올리기

Confirm alain_bkr report, same thing seen with 3.0.1 qt client.

Seems like the confusion is between "team x" (lower case t) and "Team x" (upper case T). If, as cazfi says, they are both generated, but at different times, by different functions, then that's the root of the problem.

2022-05-07 22:55 Updated by: cazfi
  • Resolution Update from None to Accepted
2022-05-10 04:09 Updated by: cazfi
댓글 올리기

Will push also to S2_6

2022-05-20 00:27 Updated by: cazfi
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed

Edit

Please login to add comment to this ticket » Login