Should fix #44370 first
Actually, many places of the code seems to attempt this already. So it might be a bug that it sometimes does not happen.
Reply To cazfi
Actually, many places of the code seems to attempt this already. So it might be a bug that it sometimes does not happen.
Yes, it's supposed to work on all branches, but climate change is buggy.
There's a long standing issue with typical rulesets where legality of the irrigating activity can depend on the irrigation of the adjacent tile. If that adjacent tile loses the irrigation for some reason, we later get an error about unit doing illegal activity.
So far we've not cared about this relative harmless thing enough to take the performance hit of (checking and) cancelling illegal unit activities also in adjacent tiles when the tile changes. Now, what might would have been a slight performance hit in earlier versions is certainly more than offset by the advancement in the hardware, so it might be time to implement the check to 3.2.