Client does not resend desired server settings after ruleset change

• Reporter: cazfi
• 소유자: cazfi
• Type: Bugs
• Status: Closed
• Component: Client common
• MileStone: 3.0.6 (closed)
• Priority: 5 - Medium
• Severity: 5 - Medium
• Resolution: Fixed
• File: 2

Details

Reported by Dino the Dinosore in http://forum.freeciv.org/f/viewtopic.php?f=9&t=92134#p104834

Server settings saved on client side ("desired settings") are not used if one changes the ruleset, i.e., does not use the default. The server does reset settings when a new ruleset is loaded, and I guess the client does not resend the desired settings after that.

Ticket History (3/14 Histories)

2022-02-01 10:55 Updated by: cazfi

• New Ticket "Client does not resend desired server settings after ruleset change" created

2022-02-01 11:45 Updated by: cazfi

• 소유자 Update from (None) to cazfi

2022-02-13 10:10 Updated by: cazfi

• File 0026-Resend-desired-server-settings-after-a-new-ruleset-h.patch (File ID: 8506) is attached

2022-02-13 10:10 Updated by: cazfi

• File 0005-Resend-desired-server-settings-after-a-new-ruleset-h.patch (File ID: 8507) is attached

2022-02-13 10:10 Updated by: cazfi

• Resolution Update from None to Accepted

2022-02-19 15:41 Updated by: cazfi

• Resolution Update from Accepted to None

댓글 올리기

Keeping this one on hold for now. I think that together with #43748 the *fix* causes any ruleset one changes to get polluted by settings from the default ruleset game.ruleset.

2022-03-18 04:44 Updated by: cazfi

• Milestone Update from 3.0.1 (closed) to 3.0.2 (closed)

댓글 올리기

Reply To cazfi

Keeping this one on hold for now.

I don't believe this can happen before 3.0.1

2022-04-09 07:56 Updated by: cazfi

댓글 올리기

There's also regression related to 'topology' setting. This causes it to get sent also when saved game is loaded, triggering server's error about the fact that the setting cannot be changed after game has begun.

2022-06-11 21:52 Updated by: cazfi

• 소유자 Update from cazfi to (None)
• Milestone Update from 3.0.2 (closed) to 3.0.3 (closed)

2022-08-05 08:57 Updated by: cazfi

• Milestone Update from 3.0.3 (closed) to 3.0.4 (closed)

2022-10-07 09:26 Updated by: cazfi

• Milestone Update from 3.0.4 (closed) to 3.0.5 (closed)

2022-12-06 22:25 Updated by: cazfi

• Milestone Update from 3.0.5 (closed) to 3.0.6 (closed)

댓글 올리기

Reply To cazfi

Keeping this one on hold for now. I think that together with #43748

#43748 targeted to 3.0.6 now, so hopefully this one can be handled then too.

2022-12-31 01:48 Updated by: cazfi

• 소유자 Update from (None) to cazfi
• Resolution Update from None to Accepted

댓글 올리기

Reply To cazfi

Reply To cazfi

Keeping this one on hold for now. I think that together with #43748

#43748 targeted to 3.0.6 now, so hopefully this one can be handled then too.

#43748 in. The original patches, from last February, attached here still apply.

2023-01-04 12:29 Updated by: cazfi

• Status Update from Open to Closed
• Resolution Update from Accepted to Fixed