gui-gtk* : F2 units and F5 economy : add an empty column for scrollbar to prevent hidding last column content
alain_bkr alain_bkr alain_bkr alain_bkr The problems comes from the scrollbar which appears on the right side when the list is too big. The scrollbar overlaps the column, and thus hides its content.
The same thing happens for F2-units report.
alain_bkr)
alain_bkr alain_bkr alain_bkr patch adds an empty column for the scrollbar
Done on
commit c7ddb47e46c9acc73eefaaeb649824249d3902f6 (HEAD -> S3_0, origin/S3_0) Date: Thu Apr 22 04:54:14 2021 +0300
alain_bkr)
Is gtk3-client affected?
In S3_1/master also gui-gtk-4.0 (gtk3x-client) should be patched (if trivial). Don't worry if you can't compile it, we don't expect contributors to test changes to it, just to provide same changes than are being made to gtk3.22-client.
alain_bkr alain_bkr A patch fixing F2 (not F4 ) and F5 problem of scrollbar overlapping dat
alain_bkr alain_bkr Reply To cazfi
Is gtk3-client affected? In S3_1/master also gui-gtk-4.0 (gtk3x-client) should be patched (if trivial). Don't worry if you can't compile it, we don't expect contributors to test changes to it, just to provide same changes than are being made to gtk3.22-client.
It is on gtk-3.22 client
I'll have a look at 3_1 / gtk-4 , the patch is rather simple so i am confident.
alain_bkr alain_bkr alain_bkr alain_bkr alain_bkr Reply To alain_bkr
Reply To cazfi
Is gtk3-client affected? In S3_1/master also gui-gtk-4.0 (gtk3x-client) should be patched (if trivial). Don't worry if you can't compile it, we don't expect contributors to test changes to it, just to provide same changes than are being made to gtk3.22-client.
It is on gtk-3.22 client
Reply To alain_bkr
I'll have a look at 3_1 / gtk-4 , the patch is rather simple so i am confident.
Most of the time you can fix all the gtk-clients by creating patch for one (for example gtk3.22), and then 'patch -u -p3 -d client/gui-gtk-3.0 < gtk3.22_fix.patch' & 'patch -u -p3 -d client/gui-gtk-4.0 < gtk3.22_fix.patch'
alain_bkr thanks for git tips :-)
I made 2 patches . one for 2_6 and 3_0 , concerning gtk3* one for 3_1 , concerning gtk3.22 and gtk4
alain_bkr alain_bkr alain_bkr alain_bkr thanks for git tips :-)
I made 2 patches .
They apply without problem , with zero or 1 line offset
Shouldn't it be 3 patches:
master: gtk3.22, gtk4
S3_1: gtk3.22, gtk3, gtk4
S3_0 & S2_6: gtk3.22, gtk3
alain_bkr alain_bkr alain_bkr alain_bkr alain_bkr alain_bkr alain_bkr There are too any branches and versions for my poor git knowledge. So I attached 3 patches, one for each gtk-version.
I made them per-branch patches. As you had not made your patches with 'git format-patch', you were not set as the author in any case (it's going to show up me as the author, with credits to you in the commit message).
3.0beta2 (but i believe it is already in 2.6 )
with gtk3.2 client, the "F5" economy view does not always show the last column ' total' .
Everything is ok while names are short (as in the begining of the game) With buildings with long names such as aqueduc_lake (and maybe when they need two digit) , the last column is getting squeezed and becomes unreadable.