Ticket #41859

alien: Requirement {Local UnitClassFlag HutFrighten} mentions HutFrighten but it will never be there

오픈 날짜: 2021-03-26 10:26 마지막 업데이트: 2021-05-02 06:21

Reporter:
소유자:
Type:
Status:
Closed
Component:
MileStone:
Priority:
5 - Medium
Severity:
5 - Medium
Resolution:
Fixed
File:
1

Details

Seen on S3_1 autogame logs (autoalien.serv sets alien ruleset to use):

1: - 2021/03/26 00:56:10 in read_init_script_real() [../../src/server/stdinhand.c::1208]: Loading script file '/work/freeciv/fc_test/autogames/autoalien.serv'.

2: - 2021/03/26 00:56:10 in do_log_deprecation() [../../src/utility/deprecations.c::65]: Requirement {Local UnitClassFlag HutFrighten} mentions HutFrighten but it will never be there.

Ticket History (3/8 Histories)

2021-03-26 10:26 Updated by: cazfi
  • New Ticket "alien: Requirement {Local UnitClassFlag HutFrighten} mentions HutFrighten but it will never be there" created
2021-03-26 11:42 Updated by: cazfi
댓글 올리기

This is more than a ruleset error. It seems that the engine allows no correct way. Either we have the requirement and get that warning, or we don't have the requirement and get error:

1: All action enablers for Paradrop Unit Enter must require that the actor unit doesn't have the HutFrighten unit class flag.

2021-04-22 03:38 Updated by: cazfi
댓글 올리기

This affects many rulesets, and thus causes a lot of spam in my autogame testing logs. Do we have any idea what should be done with this?

2021-04-28 11:02 Updated by: cazfi
댓글 올리기

Reply To cazfi

This affects many rulesets, and thus causes a lot of spam in my autogame testing logs. Do we have any idea what should be done with this?

Sveinung? Do you think we can have some resolution to this before S3_1-alpha1?

2021-04-28 19:24 Updated by: kvilhaugsvik
  • 소유자 Update from (None) to kvilhaugsvik
  • Resolution Update from None to Accepted
  • Milestone Update from (None) to 3.1.0 (closed)
  • Component Update from (None) to Rulesets
댓글 올리기

Reply To cazfi

This affects many rulesets, and thus causes a lot of spam in my autogame testing logs.

Patch for alien and civ1 attached.

Do we have any idea what should be done with this?

Patch depends on #42095 that considers an obligatory hard requirement alternative fulfilled if a universal that never is there is required to be absent

2021-04-28 19:34 Updated by: cazfi
댓글 올리기

Thank you. That is one obstacle less for 3.1.

2021-05-02 06:21 Updated by: kvilhaugsvik
  • Status Update from Open to Closed
  • Resolution Update from Accepted to Fixed
댓글 올리기

Reply To cazfi

Thank you. That is one obstacle less for 3.1.

You are welcome

Edit

Please login to add comment to this ticket » Login