Move action actions and enabler to separate file
Reply To kvilhaugsvik
in the bundled rulesets and include the file.
My plan would be to introduce new enablers.ruleset, not just split game.ruleset.
this seems necessary for custom actions so i am planning on doing this ticket, just to be sure so that i don't forget anything, this includes moving action related configs and actions enablers to a actions.ruleset , and updating the packaged rulesets to work with this change and then going to the wiki and documenting this change or is updating the doc directory sufficient? also just to be sure but right now no one is currently working on this right? it doesn't show an owner for this ticket.
Great!
This is a bit too big thing for a single ticket. I'll split this to some steps -> start by #45037
Reply To cazfi
Great! This is a bit too big thing for a single ticket. I'll split this to some steps -> start by #45037
hmm,so the thing is, i am kinda impatient so i started work on this as soon as i commented, and as it is just copy and pasting code, so i have done a lot of progress, around 12000 lines of change(almost all by copy pasting from the game.ruleset to the new file actions.ruleset file for each ruleset so 6000 "deleted' and 6000 "added") , and have added a new function on the ruleset.c file, but i haven't touched any part about build or installation,and haven't thought at all about compatibility, i have no idea what do next as i have kinda broken the logical sequence of steps. can i send the part i already did here, then you can tell me what i should do next?
Reply To dark-ether
(almost all by copy pasting from the game.ruleset to the new file actions.ruleset file for each ruleset so 6000 "deleted' and 6000 "added")
That copy+paste doesn't sound like a big task to redo when it's the correct time to do it.
I'd recommend that you keep your current patch around as a reference, and something where you can copy parts from, but that you start now from scratch in the order that things can actually be merged (we can't break the things even during the intermediate steps)
in the bundled rulesets and include the file. The action stuff is starting to totally dominate game.ruleset
Consider doing this for rulesaving too
- #45037 (done)
- #45039 (closed)
- #45064 (done)
- #45065 (done)
- #46427 (done)
- #45066 (done)