#46448: Stop accepting NULL target to terrain_extra_removal_time() Open Date: 2023-01-04 09:39 Last Update: 2023-01-28 02:59 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/46448 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46448 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2023-01-28 02:59 Updated by: cazfi * Owner Update from (None) to cazfi * Resolution Update from None to Accepted --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Patches Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.2.0 Component: General Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: terrain_extra_removal_time() can not accept NULL target when the removal times go target specific. Make sure it's never called with NULL target, and drop the handling of NULL target within. Rewrite of calc_activity() in #46447 should resolve calls from there. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/46448 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46448