#45885: Support "Tile" range for "Building" req Open Date: 2022-10-17 00:56 Last Update: 2022-10-20 01:09 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/45885 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45885 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-10-20 01:09 Updated by: cazfi Comment: + if (context->tile == NULL) { + /* RPT_CERTAIN: Can't be. No tile to contain it. + * RPT_POSSIBLE: A tile city like that may exist but not be passed. */ + return prob_type == RPT_CERTAIN; + } Umh. Should that be '!=' ? Now you return TRUE for RPT_CERTAIN when tile is NULL. -- Should is_req_knowable() have handling for Small Wonders equivalent to Great Wonder handling? Would depend on game.ruleset wonder_visibility.small_wonders -- "A city ... must not stay ..." Might be because I'm not native speaker, but to me that sounds like the city should not be a moving one. --------------------------------------------------------------------- Ticket Status: Reporter: ihnatus Owner: (None) Type: Feature Requests Status: Open Priority: 5 - Medium MileStone: (None) Component: (None) Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: Checks if a city on target tile has the improvement. Currently, it can be used only in "Unit_Bribe_Cost_Pct" effect in the rare case when you bribe a unit in a city. But it is necessary for check connectivity of two cities with airports as soon as we have such an effect (see HRM#879656) -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/45885 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45885