#43597: installer_cross: Cleanup passing parameters to nsi creation scripts
Open Date: 2022-01-11 11:25
Last Update: 2022-01-18 14:13
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/43597
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43597
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-01-18 14:13 Updated by: cazfi
* Status Update from Open to Closed
* Owner Update from (None) to cazfi
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Patches
Status: Closed
Priority: 5 - Medium
MileStone: 3.0.0
Component: Windows Installers
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
As far as I know, it's not currently causing actual ill effects, but passing parameters to nsi creation scripts from installer_build.sh has a couple of issues
- uninstaller parameter gets given after the output redirection - not very clean or readable
- When building Qt-client, $MPGUI is not set. It's sheer luck that neither is later parameter ($UNISTALLER) that would get erroneously passed in wrong position
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/43597
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43597