Commit: f1f3627b6a7f8cbf21683c5456f1d405f82daaa2 - amalsyah12 (git)

firtst release

Commit MetaInfo

• Revision: f1f3627b6a7f8cbf21683c5456f1d405f82daaa2 (tree)
• Time: 2019-01-07 19:07:39
• Author: Kyotaro Horiguchi <horiguchi.kyotaro@lab....>
• Commiter: Kyotaro Horiguchi

Log Message

Remove an useless variable

commit 64ab47b made the variable stmt_name useless. Remove it.

Change Summary

• modified: pg_hint_plan.c

Incremental Difference

--- a/pg_hint_plan.c
+++ b/pg_hint_plan.c
@@ -492,12 +492,6 @@ static HintState *current_hint = NULL;
  */
 static List *HintStateStack = NIL;
 
-/*
- * Holds statement name during executing EXECUTE command.  NULL for other
- * statements.
- */
-static char	   *stmt_name = NULL;
-
 static const HintParser parsers[] = {
 	{HINT_SEQSCAN, ScanMethodHintCreate, HINT_KEYWORD_SEQSCAN},
 	{HINT_INDEXSCAN, ScanMethodHintCreate, HINT_KEYWORD_INDEXSCAN},
@@ -2592,8 +2586,8 @@ pg_hint_plan_post_parse_analyze(ParseState *pstate, Query *query)
 
 	if (debug_level > 1)
 	{
-		if (debug_level == 1 &&
-			(stmt_name || strcmp(query_str, debug_query_string)))
+		if (debug_level == 1 && query_str && debug_query_string &&
+			strcmp(query_str, debug_query_string))
 			ereport(pg_hint_plan_debug_message_level,
 					(errmsg("hints in comment=\"%s\"",
 							current_hint_str ? current_hint_str : "(none)"),
@@ -2601,9 +2595,10 @@ pg_hint_plan_post_parse_analyze(ParseState *pstate, Query *query)
 					 errhidecontext(msgqno != qno)));
 		else
 			ereport(pg_hint_plan_debug_message_level,
-					(errmsg("hints in comment=\"%s\", stmt=\"%s\", query=\"%s\", debug_query_string=\"%s\"",
+					(errmsg("hints in comment=\"%s\", query=\"%s\", debug_query_string=\"%s\"",
 							current_hint_str ? current_hint_str : "(none)",
-							stmt_name, query_str, debug_query_string),
+							query_str ? query_str : "(none)",
+							debug_query_string ? debug_query_string : "(none)"),
 					 errhidestmt(msgqno != qno),
 					 errhidecontext(msgqno != qno)));
 		msgqno = qno;