Lua: API to unhardcode autoupgrade
Done. Based on a patch from #43778
default case from api_methods_unit_transform_problem() switch should be removed, and the assert placed after the block (all valid 'uu' values cause function to return from inside the switch). That way we get compiler warning in the future if there's a new 'enum unit_upgrade_result' added, but not handled in the switch.
Switch edited.
Patch looks good to me (haven't tested it yet). The only concern is that is this future-proof (to not cause compatibility issues) concerning what ever way #43251 will get resolved.
Git was complaining about a new trailing whitespace. Attached version with that fixed.
Reply To cazfi
The only concern is that is this future-proof (to not cause compatibility issues) concerning what ever way #43251 will get resolved.
Beginning review period regardless. People have 36h to comment, and that includes possibility to comment about #43251 compatibility.
Reply To cazfi
Git was complaining about a new trailing whitespace. Attached version with that fixed. Reply To cazfi
The only concern is that is this future-proof (to not cause compatibility issues) concerning what ever way #43251 will get resolved.
Beginning review period regardless. People have 36h to comment, and that includes possibility to comment about #43251 compatibility.
My own take is that after this goes in (and to a released datafile format), we just need to resolve #43251 in a way that retains compatibility. It can add stuff, but will have some limitations how it can rework existing functionality.
This is a sub-task of #42659. Needed functions (test ones are probably common, edit ones are server scripting):