• R/O
  • HTTP
  • SSH
  • HTTPS

kde-workspace: Commit

Katana workspace


Commit MetaInfo

Revision264cb151f96d26e9f74587d957b7b00bd4591289 (tree)
Time2022-12-09 19:30:31
AuthorIvailo Monev <xakepa10@gmai...>
CommiterIvailo Monev

Log Message

ksmserver: log backtrace in case of crash

if it crashes a startup error will be shown via xmessage, there will
be not window manager (most likely) at that point and many things will
not work as expected.

ksmserver cannot be restarted for example, drkonqi is not option either
because attempting to report a bug will open a browser but the backtrace
cannot be copied (the browser window will be on top of any other window
if it launches with no way to switch to the drkonqi window), etc.

in other words - the best thing that can be done is log the backtrace to
the system log (the ksmserver debug area has to be configured for that)

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>

Change Summary

Incremental Difference

--- a/ksmserver/main.cpp
+++ b/ksmserver/main.cpp
@@ -45,6 +45,7 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
4545 #include <kconfig.h>
4646 #include <kselectionowner.h>
4747 #include <kwindowsystem.h>
48+#include <kcrash.h>
4849 #include <QtGui/qx11info_x11.h>
4950 #include <QtCore/qfile.h>
5051
@@ -230,6 +231,8 @@ int main( int argc, char* argv[] )
230231
231232 KApplication::quitOnSignal();
232233
234+ KCrash::setFlags(KCrash::Backtrace);
235+
233236 // for the KDE-already-running check in startkde
234237 KSelectionOwner kde_running( "_KDE_RUNNING", 0 );
235238 kde_running.claim( false );
Show on old repository browser