Android-x86
Fork
Donation

  • R/O
  • HTTP
  • SSH
  • HTTPS

packages-apps-Bluetooth: List of commits

packages/apps/Bluetooth


RSS
Rev. Time Author
c6ab83c oreo-x86 2017-11-23 23:47:30 Hans Månsson

AdapterProperties: Guard unregisterReceiver

At first boot if Bluetooth is not enabled by default the Bluetooth app
will crash due to a poorly guarded cleanup method.

The root cause is that BluetoothMangerService.handleOnBootPhase() issues
a MESSAGE_GET_NAME_AND_ADDRESS, which inturn will try get device address
and name. When done it will call unbindAndFinish() if Bluetooth is not
enabled. The Bluetooth app then cleans up in preparation for shutdown
and the crash occurs.

Test: def_bluetooth_on => false in SettingsProvider defaults. Build/boot
Change-Id: Idc6817eacd75fcc22d284ca0e54933914b587e49

17ca6dd 2017-08-29 03:43:19 android-build-team Robot

Merge cherrypicks of [2805728, 2805966] into oc-r5-release

Change-Id: I448e262d28436d256d901d86f9acc3549a6cc9c9

f51e3ac 2017-08-29 03:42:49 Ajay Panicker

Improve AVRCP quality and state handling (1/2)

Bug: 64749777
Test: Play music with various car kits and see that metadata shows up
See go/oc-avrcp-sotu - 8/15/20 OC + Patches for further info
Change-Id: Ia9dd450860f5bc54bd249322bfb9762c6235dc32
(cherry picked from commit 6b95520b8fe8a5bd8bc264e06bec51f3591d2507)

f50ee88 2017-08-15 06:46:05 android-build-team Robot

release-request-49e3b466-076f-42b5-804c-ed9aab783aec-for-git_oc-r5-release-4255676 snap-temp-L37500000092850661

Change-Id: I0c2724b9c89231dca0166b7e62e9a5a4dfca3d4f

1f0137c 2017-07-29 02:25:45 android-build-team Robot

Merge cherrypicks of [2622852, 2622193, 2622194, 2622195, 2622933, 2622990, 2622991, 2622992, 2622993, 2622994, 2622995, 2622934, 2622196, 2622975, 2622996, 2622997, 2622998, 2623050, 2622935, 2622197, 2623051, 2622936, 2622918, 2622919, 2622999] into oc-release

Change-Id: I89bf7b4c5c90c09ed87de04b0433cdcab101440c

418d6e3 2017-07-29 02:23:02 Bill Yi

Import translations. DO NOT MERGE

Change-Id: If44ad0f9a0a92dcce2786f89487d1f6ef92f65a0
Auto-generated-cl: translation import
Exempt-From-Owner-Approval: translation import
(cherry picked from commit ad273a8c33d1072df6639efcd87507dbf7064f96)

c379b32 2017-06-24 10:25:35 android-build-team Robot

Merge cherrypicks of [2455372, 2455337, 2455612, 2455497] into oc-release

Change-Id: I05e7158e88bbdba30984eac8f4ab0eaf8cb0a55c

3e25ade 2017-06-24 10:25:10 Ajay Panicker

AVRCP: Fix NowPlayingList looping

When a controller requested GetFolderItems, we would sometimes send a
NowPlayingListChanged before responding to GetFolderItems, prompting a
new GetFolderItems request. This put us in an infinite loop.

Test: connect to BMW and note it actually works
Bug: 62775732

Change-Id: Idc669a03f71ed9ec6b211bb5c33fc98548cc9f85
(cherry picked from commit d65422f9b47bff59b12162fc51032eb633f0722f)

1ab97a2 2017-06-24 10:24:59 Marie Janssen

Avrcp: Limit available players changed

According to the spec, we should only send an Available Players Changed
update when a player is added or removed. (AVRCP 1.6.1 Sec 6.9.4 p74)

Only send an update when a player is added or removed. If a player
would change feature bits, display name, major or minor type, present it
as a new player instead and remove the old player.

Sync available players notifications with other notifications.

Bug: 34471252
Test: switch players, note that Available Players Changed is not sent
all the time
Change-Id: Icd3730afa6e182810920f28fa7db17b98e53ceea
(cherry picked from commit f2f6a4ea02e9456f71ea0490112845110ca5d975)
(cherry picked from commit 85ff6903243d244d4342f390bb40aa99097a9a7c)

25343be 2017-06-24 10:24:49 Marie Janssen

Avrcp: refactor addressed player notifications

The time when audio players change is a time of great changes in the Media
Framework. Many things are updated at the same time, and controllers
are updating three or four times before Metadata is stable for sending
to the controller.

Accordingly, when media updates happen, we can wait a little bit to
update media info when it changes to let it settle.

Refactor sending addressed player changes, resetting notifications when
we are supposed to, and check for an update whenever we update media.

Only update media at max every second.

Test: connect to carkit, change apps, notice media appears
Bug: 34471252
Change-Id: I6f0a5e169bece69894d1139a2b6615fac6b08a48
(cherry picked from commit 59b1c77f883bd97816332046a3a98be4431ccedd)
(cherry picked from commit b631457c5ccc472a499334f65b88848bbaf3c605)

a861c97 2017-06-23 16:10:54 android-build-team Robot

release-request-160c4b31-7fa0-4e2b-aabe-85380836a1ce-for-git_oc-release-4129081 snap-temp-L15300000077039010

Change-Id: Id006a211bca6b526a92cc2861e3e2efdc19b8881

90cad4d 2017-06-23 03:28:34 TreeHugger Robot

Merge "Add a missing check for null pointer during closing of PBAP Service" into oc-dev

913d7ac 2017-06-22 16:11:39 android-build-team Robot

release-request-767e2998-9243-43e0-b656-1acb30ac5115-for-git_oc-release-4124637 snap-temp-L74200000076595014

Change-Id: I0c0722e17efcae75db01b8906b68d5374510c7ca

029b34a 2017-06-22 10:18:31 Marie Janssen

Avrcp: redact media info

Let's redact some of that media info when we're not on debug/eng builds.

Test: play some music, adb logcat and observe
Bug: 62826797
Change-Id: Icf7e926508215eae70cd75bef3cddcc001218c50
(cherry picked from commit cc07ee436d00418ecc69ae3aace986f7fbf0823a)

75911df 2017-06-22 09:49:04 Pavlin Radoslavov

Add a missing check for null pointer during closing of PBAP Service

This fixes NullPointerException when processing MSG_SERVERSESSION_CLOSE
from the Obex Server if Bluetooth itself is shutting down.

BluetoothPbapService.closeService() ->
BluetoothPbapObexServer.onClose() -> msg(MSG_SERVERSESSION_CLOSE) -> ...
-> BluetoothPbapService.stopObexServerSession()
-> mAdapter.isEnabled() -> NPE (mAdapter is null)

Bug: 62073087
Test: Code compilation
Change-Id: Ica98e1b784b3a51456c7709062074ea122eb8bdd
(cherry picked from commit d5a30661a5c51e5f02320868ec870709c1c0ecac)

6767682 2017-06-21 04:21:25 Marie Janssen

AVRCP: Prevent multithread issues in cleanup

When cleaning up the object in doQuit it was possible to have multiple
threads updating at once, causing NullPointerExceptions in some cases.

Synchronize the startup and shutdown of the Avrcp object to prevent
this.

Test: toggle bluetooth rapidly
Bug: 62676895
Change-Id: I2618c7d7b21acb1f95cb67366d469da2fa88d4a4
(cherry picked from commit 9a5f80a6528d76153a7e97821f114f3370df89a5)

5cdb68d 2017-06-14 16:10:08 android-build-team Robot

release-request-0b3ce0b0-0f38-494b-a590-b594ba11c2d2-for-git_oc-release-4098933 snap-temp-L41500000074000728

Change-Id: I0bddcefa830bfd24f27f1025a87564e3ab6197d0

d5b2445 2017-06-14 07:36:06 Marie Janssen

AVRCP: Workaround Queue ID & metadata updates

When a player with a queue updates their track, it comes in two separate
parts from MediaController.Callback:
- Queue ID is in onPlaybackStateChanged
- Metadata is in onMetadataChanged

Because the ordering of these two is not specific, both must change
before we have a consistent data state to present the carkit if the
Media client has a queue.

Even though the only thing sent in the Track Changed notification is the
Queue ID, the request for metadata often comes before the Metadata has
been updated after that notification.

Refactor Track Changed notification to keep track of the last data we
sent to the controller, and send new tracks when both Queue ID and
Metadata have changed.

Test: various carkit testing with track skipping
Bug: 37707672
Change-Id: Ibf9f725f6912955a65421786068921489dbf8e45
(cherry picked from commit 5aca05c1d79f3412b6964b3b6335ad6f2d558756)

0ce2c58 2017-06-14 04:09:20 Calvin On

Work around/prevent NPE in aclStateChangedCallback.

Bug: 62440980
Change-Id: I0fd02d80a9cb656a253e537a4ce2dd538df4c48d

409f3d7 2017-06-14 02:55:34 Calvin On

Work around/prevent NPE in aclStateChangedCallback. am: ffe43a054b
am: f76c8861f6 -s ours

Change-Id: I2ed091e0c43366f2fdba8931efe35202b78167a7

cb6680f 2017-06-13 16:09:26 android-build-team Robot

release-request-7d12f16b-b4a7-4324-8b59-be2d4e07dcb3-for-git_oc-release-4094438 snap-temp-L80000000073561277

Change-Id: I4e38097bc3cf02d9dc8a8e24375fa366a4a2dd98

b716d63 2017-06-13 10:03:04 TreeHugger Robot

Merge "AVRCP: reduce PLAY_INTERVAL_TIMEOUT logspam" into oc-dev

f76c886 2017-06-13 08:06:36 Calvin On

Work around/prevent NPE in aclStateChangedCallback.
am: ffe43a054b

Change-Id: I462bc866296419519b059232d64305cf0357ddca

a06a7e9 2017-06-13 07:53:45 Marie Janssen

AVRCP: reduce PLAY_INTERVAL_TIMEOUT logspam

Before:
06-10 20:38:36.926 1002 1520 2053 V Avrcp : MSG_NATIVE_REQ_REGISTER_NOTIFICATION:event=5 param=1
06-10 20:38:36.926 1002 1520 2053 D Avrcp : sendPlayPosNotificationRsp: (true) 193004 <=? 194015 <=? 195004
06-10 20:38:36.926 1002 1520 2053 D Avrcp : sendPlayPosNotificationRsp: currentPlayState PlaybackState {state=3, position=698, buffered position=0, speed=1.0, updated=76557851, actions=794551, custom actions=[Action:mName='Thumbs up, mIcon=2130838014, mExtras=Bundle[mParcelledData.dataSize=40], Action:mName='Thumbs down, mIcon=2130838013, mExtras=Bundle[mParcelledData.dataSize=44], Action:mName='Start radio, mIcon=2130837971, mExtras=Bundle[mParcelledData.dataSize=648], Action:mName='Shuffle, mIcon=2130837998, mExtras=null], active item id=27596, error=null}
06-10 20:38:36.926 1002 1520 2053 D Avrcp : PLAY_INTERVAL_TIMEOUT set for 1000ms from now
06-10 20:38:37.928 1002 1520 2053 V Avrcp : MSG_PLAY_INTERVAL_TIMEOUT
06-10 20:38:37.928 1002 1520 2053 D Avrcp : sendPlayPosNotificationRsp: (false) 193015 <=? 195017 <=? 195015
06-10 20:38:37.928 1002 1520 2053 D Avrcp : sendPlayPosNotificationRsp: currentPlayState PlaybackState {state=3, position=698, buffered position=0, speed=1.0, updated=76557851, actions=794551, custom actions=[Action:mName='Thumbs up, mIcon=2130838014, mExtras=Bundle[mParcelledData.dataSize=40], Action:mName='Thumbs down, mIcon=2130838013, mExtras=Bundle[mParcelledData.dataSize=44], Action:mName='Start radio, mIcon=2130837971, mExtras=Bundle[mParcelledData.dataSize=648], Action:mName='Shuffle, mIcon=2130837998, mExtras=null], active item id=27596, error=null}

After:
06-12 14:27:38.217 1217 1807 V Avrcp : MSG_NATIVE_REQ_REGISTER_NOTIFICATION:event=5 param=5
06-12 14:27:38.218 1217 1807 D Avrcp : sendPlayPosNotificationRsp: (true) 56305 <=? 61489 <=? 66305 Playing State: 3 Timeout 5000ms
06-12 14:27:43.225 1217 1807 D Avrcp : sendPlayPosNotificationRsp: (false) 56489 <=? 66495 <=? 66489 Playing State: 3

Test: adb logcat when playing music and connected to a device
Bug: 36802046
Change-Id: Icb3623c51ceaf0e70f3da9beb1f0a2896b4cfd65
(cherry picked from commit 0ace2d5941549e466ada4258c6c6fbb1debdf48d)

4ffc876 2017-06-13 07:22:49 Marie Janssen

AVRCP: fix single item queue Now Playing issues

When queried (and in track change notifications) we previously returned
an item ID not allowed by the spec (0xFFFFFFFFFFFFFFFF) to a controller
when presenting a "single item queue" because the player doesn't provide
one.

Refactor the code so that the single item queue is persisted and send
NOW_PLAYING_CONTENT_CHANGED when the single item queue updates.

Tweak debugging of mediacontrollers for easier player debugging.

Test: check media info on honda carkit w/fm.player app
Bug: 62288178
Change-Id: Ic37d0c4c837436e102e9642e1f8e36e17e0dc254
(cherry picked from commit 3a80469f095e51f9be3965d67fff595eabc00293)

ffe43a0 2017-06-13 04:49:11 Calvin On

Work around/prevent NPE in aclStateChangedCallback.

Bug: 62440980
Change-Id: I0fd02d80a9cb656a253e537a4ce2dd538df4c48d

9fd8f05 2017-06-11 16:15:09 android-build-team Robot

release-request-276f9f52-87fd-4915-bd79-9a2f0ee77433-for-git_oc-release-4090213 snap-temp-L31600000073091223

Change-Id: Ia3aa2ea96f76d6f083489e5b53fb9433709bedae

91e595b 2017-06-10 03:22:19 Hemant Gupta

PBAP: Implement Folder Version Counter(s)

Primary version counter should be updated on any change to
contact. Secondary version counter should not update when
there is change to fields other than F, FN, TEL, EMAIL or
ADDRESS. There is no default API available in android to determine
which field is updated as required for updating secondary
version counter. Implemented logic to increment the secondary
version counter by comparing updated contacts with old cached
contacts of the contact database.

Test: Verified that folder version counter gets incremented for
change(s) in fields of Contacts as per PBAP specification.
TestTracker: 89053
Bug: 33011817
Change-Id: I90a1ced3713c369bcde0edd627bbde57a9676708
(cherry picked from commit cf92c2759b709461acf7c36c08f4eef9c8004c85)

cecda82 2017-06-10 03:21:15 Hemant Gupta

PBAP: Add support for PBAP 1.2

Add changes required to do the SDP registration as
supported by 1.2, L2CAP related functionality and counter
related changes to support PBAP 1.2.

Test: Connected with Remote PBAP Client supporting PBAP 1.2 and
verified that connection and transfer happens over L2CAP.
Connected with Remote PBAP Client supporting PBAP 1.1 and
and verified that connection and transfer happens over RFCOMM.
TestTracker: 89053

Bug: 33011817
Change-Id: Iddace24f43a7618ccbe6a9b49bcab88dbaae0e06
(cherry picked from commit 5a37bc407ab1b8844c3541ff4e6653635b108bed)

75d921e 2017-06-09 08:59:28 Pavlin Radoslavov

Initialize the RemoteDevice Class Of Device to UNCATEGORIZED

Bug: 37615863
Test: Manual with LG HBS1100 headset
Change-Id: I0420cd517f77a4c8965c6651a24f97c29ae99f7f
(cherry picked from commit 2c5969fcd9beac52e4218d66f7f47d8ea901647a)

Show on old repository browser