Android-x86
Fork
Donation

  • R/O
  • HTTP
  • SSH
  • HTTPS

external-llvm: Commit

external/llvm


Commit MetaInfo

Revision3ffa488dbe1d8498512a2bfad1367557d2c79e73 (tree)
Time2019-09-22 21:35:54
AuthorDan Willemsen <dwillemsen@goog...>
CommiterMauro Rossi

Log Message

Add SourceFileGenerator.GeneratedDeps()

To clean up unnecessary dependencies when using generated headers,
GeneratedDeps() should return a single file from every build entry.
GeneratedSourceFiles() used to be used from this, but now if you create
one build rule with multiple outputs, it's valid to only return a single
output file.

In this case, ModuleBuild is called once per source file, each
outputing a single output file, so all of them still need to be listed.

Bug: 73745773
Test: diff out/soong/build.ninja
Test: diff out/soong/Android-aosp_arm.mk
Test: rm -rf out; m
Change-Id: I073e3be7ecd9545f4002ad94d3da44f1a6652baa

Change Summary

Incremental Difference

--- a/soong/tblgen.go
+++ b/soong/tblgen.go
@@ -162,6 +162,10 @@ func (t *tblgen) GeneratedHeaderDirs() android.Paths {
162162 }
163163
164164 func (t *tblgen) GeneratedSourceFiles() android.Paths {
165+ return nil
166+}
167+
168+func (t *tblgen) GeneratedDeps() android.Paths {
165169 return t.generatedHeaders
166170 }
167171
Show on old repository browser